Split (1)

train · 90 rows

instance_id string	hints_text string	patch string	test_patch string	created_at string	problem_statement string	repo string	base_commit string	version string	PASS_TO_PASS list	FAIL_TO_PASS list	eval_script string	__index_level_0__ int64
getmoto__moto-6641	Hi @JAChez, thanks for raising this, and welcome to Moto! Marking it as an an enhancement to add this validation.	diff --git a/moto/scheduler/exceptions.py b/moto/scheduler/exceptions.py --- a/moto/scheduler/exceptions.py +++ b/moto/scheduler/exceptions.py @@ -2,6 +2,11 @@ from moto.core.exceptions import JsonRESTError +class ScheduleExists(JsonRESTError): + def __init__(self, name: str) -> None: + super().__init__(...	diff --git a/tests/test_scheduler/test_scheduler.py b/tests/test_scheduler/test_scheduler.py --- a/tests/test_scheduler/test_scheduler.py +++ b/tests/test_scheduler/test_scheduler.py @@ -144,6 +144,26 @@ def test_update_schedule(extra_kwargs): assert schedule["CreationDate"] != schedule["LastModificationDate"] ...	2023-08-12 18:48:17	Scheduler not raising ConflictException when duplicate schedules created Boto3 will raise a `ConflictException` when an Eventbridge schedule is created with the same name as an existing schedule. While mocking with moto, this exception is not raised. The response returns a success status and the second schedule is simp...	getmoto/moto	c8b5470e25012477f817a619e88f9ad1bea08bbe	4.1	[ "tests/test_scheduler/test_scheduler.py::test_list_schedules", "tests/test_scheduler/test_scheduler.py::test_create_get_schedule", "tests/test_scheduler/test_scheduler.py::test_create_get_delete__in_different_group", "tests/test_scheduler/test_scheduler.py::test_update_schedule[with_group]", "tests/test_sch...	[ "tests/test_scheduler/test_scheduler.py::test_create_duplicate_schedule" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff c8b5470e25012477f8...	25
getmoto__moto-4833	Hi @lynkfox, thanks for raising this. Looks like that's a bug on our side - we'll push out a fix shortly. This does work for classes that extend `unittest.TestCase`, where the setup-method should be called `setUp` (uppercase U), but not for plain classes where the `setup`-method should have a lowercase u.	diff --git a/moto/core/models.py b/moto/core/models.py --- a/moto/core/models.py +++ b/moto/core/models.py @@ -137,11 +137,15 @@ def decorate_class(self, klass): c for c in klass.__mro__ if c not in [unittest.TestCase, object] ] # Get a list of all userdefined methods - supermethod...	diff --git a/tests/test_core/test_decorator_calls.py b/tests/test_core/test_decorator_calls.py --- a/tests/test_core/test_decorator_calls.py +++ b/tests/test_core/test_decorator_calls.py @@ -109,8 +109,9 @@ def test_no_instance_sent_to_staticmethod(self): @mock_s3 -class TestWithSetup(unittest.TestCase): +class Te...	2022-02-04 23:14:17	new clients/resources do not find the resources created in Setup() Versions: moto 3.0.2 boto3 1.20.24 pytest 6.2.5 with the update past 3.0, any of our tests using moto failed with "Resource not Found" The tests originally looked something like this (which worked under 2.3.2: (create table creates ...	getmoto/moto	bb6fb1200f8db61e0d39c9a4da5954469a403fb8	3.0	[ "tests/test_core/test_decorator_calls.py::TestWithNestedClasses::TestWithSetup::test_should_not_find_bucket_from_test_method", "tests/test_core/test_decorator_calls.py::TestSetUpInBaseClass::test_a_thing", "tests/test_core/test_decorator_calls.py::TestWithInvalidSetupMethod::test_should_not_find_bucket", "tes...	[ "tests/test_core/test_decorator_calls.py::TestWithSetup_LowercaseU::test_should_find_bucket", "tests/test_core/test_decorator_calls.py::TestWithSetupMethod::test_should_find_bucket" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff bb6fb1200f8db61e0d...	42
getmoto__moto-5940	Hey @nicor88, thanks for raising this. The `VersionId` should actually be returned twice, according to the AWS docs: once as part of the key of Table, and one separate. :confused: Marking it as a bug. @bblommers ah I see, as mentioned above also UpdateTime seems missing.	diff --git a/moto/glue/models.py b/moto/glue/models.py --- a/moto/glue/models.py +++ b/moto/glue/models.py @@ -130,7 +130,7 @@ def create_table(self, database_name, table_name, table_input): database.tables[table_name] = table return table - def get_table(self, database_name, table_name): + de...	diff --git a/tests/test_glue/test_datacatalog.py b/tests/test_glue/test_datacatalog.py --- a/tests/test_glue/test_datacatalog.py +++ b/tests/test_glue/test_datacatalog.py @@ -339,11 +339,13 @@ def test_get_table_versions(): for n, ver in enumerate(vers): n = str(n + 1) ver["VersionId"].should.equ...	2023-02-16 23:00:33	Incorect response when calling glue.get_table_versions ## Reporting Bugs The current implementation of glue.get_table_versions, see [here](https://github.com/getmoto/moto/blob/78840fd71c365bb40214f59a9d7c5f5f3d00b850/moto/glue/responses.py#L73-L85) it's different from the actual response from boto3. Specifically ...	getmoto/moto	418c69f477add62271938fbf4c1b8117087f4cd8	4.1	[ "tests/test_glue/test_datacatalog.py::test_delete_database", "tests/test_glue/test_datacatalog.py::test_create_partition_already_exist", "tests/test_glue/test_datacatalog.py::test_get_partitions_empty", "tests/test_glue/test_datacatalog.py::test_create_database", "tests/test_glue/test_datacatalog.py::test_b...	[ "tests/test_glue/test_datacatalog.py::test_get_table_versions" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 418c69f477add62271...	109
getmoto__moto-5202		diff --git a/moto/s3/models.py b/moto/s3/models.py --- a/moto/s3/models.py +++ b/moto/s3/models.py @@ -32,6 +32,8 @@ BackendDict, ) from moto.cloudwatch.models import MetricDatum +from moto.moto_api import state_manager +from moto.moto_api._internal.managed_state_model import ManagedState from moto.utilities.ta...	diff --git a/tests/test_s3/test_s3.py b/tests/test_s3/test_s3.py --- a/tests/test_s3/test_s3.py +++ b/tests/test_s3/test_s3.py @@ -15,6 +15,7 @@ from freezegun import freeze_time import requests +from moto.moto_api import state_manager from moto.s3.responses import DEFAULT_REGION_NAME from unittest import SkipTes...	2022-06-08 14:54:10	Feature Request: Add support for S3 glacier restore transitions ## Feature Request Adding support for testing the transition when restoring files from S3 Glacier to standard storage class. ## Motivation When files in S3 are restored from Glacier to standard storage class, the `Restore` attribute (`x-amz-restor...	getmoto/moto	4aa5e4388d4a9a7d4a95c265552e2d4b4c1ba376	3.1	[ "tests/test_s3/test_s3.py::test_put_bucket_notification", "tests/test_s3/test_s3.py::test_get_bucket_cors", "tests/test_s3/test_s3.py::test_get_object", "tests/test_s3/test_s3.py::test_create_bucket_duplicate", "tests/test_s3/test_s3.py::test_list_objects_with_pagesize_0", "tests/test_s3/test_s3.py::test_...	[ "tests/test_s3/test_s3.py::test_restore_key_transition" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4aa5e4388d4a9a7d4a...	113
getmoto__moto-6687		diff --git a/moto/cloudtrail/models.py b/moto/cloudtrail/models.py --- a/moto/cloudtrail/models.py +++ b/moto/cloudtrail/models.py @@ -300,21 +300,22 @@ def get_trail(self, name_or_arn: str) -> Trail: def get_trail_status(self, name: str) -> TrailStatus: if len(name) < 3: raise TrailNameTooSh...	diff --git a/tests/test_cloudtrail/test_cloudtrail.py b/tests/test_cloudtrail/test_cloudtrail.py --- a/tests/test_cloudtrail/test_cloudtrail.py +++ b/tests/test_cloudtrail/test_cloudtrail.py @@ -319,6 +319,38 @@ def test_get_trail_status_after_starting_and_stopping(): assert "TimeLoggingStopped" in status # .equa...	2023-08-17 07:53:29	@mock_cloudtrail is not being able to retrieve the trail status in a different region for a multiregion trail ## Description As per the AWS Boto3 documentation, the [get_trail_status](https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/cloudtrail/client/get_trail_status.html) call is able to g...	getmoto/moto	1fe69d55a50b404d7c0a59707e88ce03c5ded784	4.1	[ "tests/test_cloudtrail/test_cloudtrail.py::test_list_trails_different_home_region_no_multiregion", "tests/test_cloudtrail/test_cloudtrail.py::test_update_trail_full", "tests/test_cloudtrail/test_cloudtrail.py::test_get_trail_unknown", "tests/test_cloudtrail/test_cloudtrail.py::test_get_trail_status_inactive",...	[ "tests/test_cloudtrail/test_cloudtrail.py::test_get_trail_status_multi_region_not_from_the_home_region" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 1fe69d55a50b404d7c...	116
getmoto__moto-6410		diff --git a/moto/moto_api/_internal/responses.py b/moto/moto_api/_internal/responses.py --- a/moto/moto_api/_internal/responses.py +++ b/moto/moto_api/_internal/responses.py @@ -68,7 +68,7 @@ def model_data( if not attr.startswith("_"): try: ...	diff --git a/tests/test_core/test_moto_api.py b/tests/test_core/test_moto_api.py --- a/tests/test_core/test_moto_api.py +++ b/tests/test_core/test_moto_api.py @@ -14,6 +14,7 @@ if settings.TEST_SERVER_MODE else "http://motoapi.amazonaws.com" ) +data_url = f"{base_url}/moto-api/data.json" @mock_sqs @@ -3...	2023-06-14 20:58:23	server: Overwriting a binary object in S3 causes `/moto-api/data.json` to fail - Moto version: 759f26c6d (git cloned) - Python version: 3.11.4 - OS: macOS 13.4 After storing a binary file in S3 on the server and overwriting it, the server's dashboard fails to load due to an unhandled exception while fe...	getmoto/moto	1dfbeed5a72a4bd57361e44441d0d06af6a2e58a	4.1	[ "tests/test_core/test_moto_api.py::test_model_data_is_emptied_as_necessary", "tests/test_core/test_moto_api.py::test_reset_api", "tests/test_core/test_moto_api.py::test_creation_error__data_api_still_returns_thing", "tests/test_core/test_moto_api.py::test_data_api", "tests/test_core/test_moto_api.py::TestMo...	[ "tests/test_core/test_moto_api.py::test_overwriting_s3_object_still_returns_data" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 1dfbeed5a72a4bd573...	118
getmoto__moto-5699		diff --git a/moto/cloudfront/responses.py b/moto/cloudfront/responses.py --- a/moto/cloudfront/responses.py +++ b/moto/cloudfront/responses.py @@ -622,6 +622,7 @@ def list_tags_for_resource(self) -> TYPE_RESPONSE: INVALIDATIONS_TEMPLATE = """<?xml version="1.0" encoding="UTF-8"?> <InvalidationList> <IsTruncated>f...	diff --git a/tests/test_cloudfront/test_cloudfront_invalidation.py b/tests/test_cloudfront/test_cloudfront_invalidation.py --- a/tests/test_cloudfront/test_cloudfront_invalidation.py +++ b/tests/test_cloudfront/test_cloudfront_invalidation.py @@ -76,4 +76,4 @@ def test_list_invalidations__no_entries(): resp["Inval...	2022-11-22 15:04:13	CloudFront: list_invalidations includes empty element if no invalidations ## How to reproduce the issue ```python @mock_cloudfront def test_list_invalidations__no_entries(): client = boto3.client("cloudfront", region_name="us-west-1") resp = client.list_invalidations( DistributionId="SPAM", ...	getmoto/moto	b4f59b771cc8a89976cbea8c889758c132d405d0	4.0	[ "tests/test_cloudfront/test_cloudfront_invalidation.py::test_list_invalidations", "tests/test_cloudfront/test_cloudfront_invalidation.py::test_create_invalidation" ]	[ "tests/test_cloudfront/test_cloudfront_invalidation.py::test_list_invalidations__no_entries" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff b4f59b771cc8a89976...	124
getmoto__moto-6756	I just ran `python scripts/scaffold.py` and typed in `sagemaker` and `list_notebook_instances`. I can't see anything added for the paginator. Is there any scaffold script to add that for me? When I run `git status` to see what the `scaffold.py` script did, I see: ``` Changes not staged for commit: (use "gi...	diff --git a/moto/sagemaker/models.py b/moto/sagemaker/models.py --- a/moto/sagemaker/models.py +++ b/moto/sagemaker/models.py @@ -29,35 +29,36 @@ "limit_key": "MaxResults", "limit_default": 100, "unique_attribute": "experiment_arn", - "fail_on_invalid_token": True, }, "list_...	diff --git a/tests/test_sagemaker/test_sagemaker_notebooks.py b/tests/test_sagemaker/test_sagemaker_notebooks.py --- a/tests/test_sagemaker/test_sagemaker_notebooks.py +++ b/tests/test_sagemaker/test_sagemaker_notebooks.py @@ -26,7 +26,7 @@ FAKE_INSTANCE_TYPE_PARAM = "ml.t2.medium" -@pytest.fixture(name="sagemaker...	2023-09-01 20:24:33	[Feature request] SageMaker list and notebook instances Currently Moto can create a fake SageMaker notebook instance, and delete it, and describe it's lifecycle config, and list tags for it. I want to add functionality to list notebook instances, including the `list_notebook_instances` paginator. This is somethin...	getmoto/moto	c59fee5d352e429309ddce7f8350ef70f2003593	4.2	[ "tests/test_sagemaker/test_sagemaker_notebooks.py::test_notebook_instance_lifecycle_config", "tests/test_sagemaker/test_sagemaker_notebooks.py::test_add_tags_to_notebook", "tests/test_sagemaker/test_sagemaker_notebooks.py::test_create_notebook_instance_params", "tests/test_sagemaker/test_sagemaker_notebooks.p...	[ "tests/test_sagemaker/test_sagemaker_notebooks.py::test_list_notebook_instances", "tests/test_sagemaker/test_sagemaker_notebooks.py::test_notebook_instance_lifecycle" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff c59fee5d352e429309...	126
getmoto__moto-4896	Hi @07pepa, thanks for raising this. The second example fails for me as well - I'll look into why that's happening later. The first example, with `mock_s3`-decorator first, does work as expected for me. My reproducible test: ``` @mock_s3 @responses.activate def test_moto_first(): moto_responses_compat...	diff --git a/moto/core/custom_responses_mock.py b/moto/core/custom_responses_mock.py --- a/moto/core/custom_responses_mock.py +++ b/moto/core/custom_responses_mock.py @@ -100,7 +100,8 @@ def not_implemented_callback(request): # - Same request, executed again, will be matched on the subsequent match, which happens to ...	diff --git a/tests/test_core/test_responses_module.py b/tests/test_core/test_responses_module.py new file mode 100644 --- /dev/null +++ b/tests/test_core/test_responses_module.py @@ -0,0 +1,63 @@ +""" +Ensure that the responses module plays nice with our mocks +""" + +import boto3 +import requests +import responses +fr...	2022-02-28 20:03:06	moto breaks repsonses library usage if moto is used with responses for mocking request responses library will be broken ```python import responses from moto import mock_s3 @mock_s3 @responses.activate def test(): responses.add( responses.POST, url='http://someurl', body="4", ...	getmoto/moto	8bbfe9c151e62952b153f483d3604b57c7e99ab6	3.0	[ "tests/test_core/test_responses_module.py::TestResponsesModule::test_moto_first" ]	[ "tests/test_core/test_responses_module.py::TestResponsesModule::test_moto_second", "tests/test_core/test_responses_module.py::TestResponsesModule::test_moto_as_late_as_possible" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8bbfe9c151e62952b1...	147
getmoto__moto-6567		diff --git a/moto/rds/models.py b/moto/rds/models.py --- a/moto/rds/models.py +++ b/moto/rds/models.py @@ -182,7 +182,7 @@ def __init__(self, **kwargs: Any): self.preferred_backup_window = "01:37-02:07" self.preferred_maintenance_window = "wed:02:40-wed:03:10" # This should default to the def...	diff --git a/tests/test_rds/test_rds_clusters.py b/tests/test_rds/test_rds_clusters.py --- a/tests/test_rds/test_rds_clusters.py +++ b/tests/test_rds/test_rds_clusters.py @@ -193,29 +193,13 @@ def test_create_db_cluster__verify_default_properties(): ).should.be.greater_than_or_equal_to(cluster["ClusterCreateTime"]...	2023-07-28 10:14:41	Missing vpc security group name from rds.create_db_cluster response ## Reporting Bugs When we provide a vpc security group id for rds.create_db_cluster, the response of this create returns an empty list for `'VpcSecurityGroups': []`. I am using boto3 & mocking this call using moto library's mock_rds method. The r...	getmoto/moto	b52fd80cb1cfd8ecc02c3ec75f481001d33c194e	4.1	[ "tests/test_rds/test_rds_clusters.py::test_start_db_cluster_without_stopping", "tests/test_rds/test_rds_clusters.py::test_modify_db_cluster_needs_long_master_user_password", "tests/test_rds/test_rds_clusters.py::test_modify_db_cluster_new_cluster_identifier", "tests/test_rds/test_rds_clusters.py::test_copy_db...	[ "tests/test_rds/test_rds_clusters.py::test_create_db_cluster_additional_parameters" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff b52fd80cb1cfd8ecc0...	152
getmoto__moto-4799	Hi @crbunney, thanks for raising this - marking it as a bug. An additional workaround is to remove the `tearDown`-method altogether for this example - Moto will reset the state automatically at the beginning of each test. I'll make sure this is better reflected in the documentation.	diff --git a/moto/core/models.py b/moto/core/models.py --- a/moto/core/models.py +++ b/moto/core/models.py @@ -127,16 +127,21 @@ def wrapper(args, *kwargs): return wrapper def decorate_class(self, klass): - direct_methods = set( - x - for x, y in klass.__dict__.items() - ...	diff --git a/tests/test_core/test_decorator_calls.py b/tests/test_core/test_decorator_calls.py --- a/tests/test_core/test_decorator_calls.py +++ b/tests/test_core/test_decorator_calls.py @@ -159,6 +159,26 @@ def test_should_not_find_bucket(self): s3.head_bucket(Bucket="mybucket") +@mock_s3 +class Basec...	2022-01-26 23:16:33	"Bucket does not exist" thrown from inherited tearDown method in moto 3.0.1 I have this code: ```python import unittest import boto3 from moto import mock_s3 @mock_s3 class BaseTest(unittest.TestCase): def setUp(self) -> None: self.s3 = boto3.resource('s3') self.test_bucket = self.s...	getmoto/moto	fc1ef55adc7e0c886602149cfe9c1dc04645952b	3.0	[ "tests/test_core/test_decorator_calls.py::TestWithNestedClasses::TestWithSetup::test_should_not_find_bucket_from_test_method", "tests/test_core/test_decorator_calls.py::test_context_manager", "tests/test_core/test_decorator_calls.py::Tester::test_still_the_same", "tests/test_core/test_decorator_calls.py::Test...	[ "tests/test_core/test_decorator_calls.py::TestSetUpInBaseClass::test_a_thing" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff fc1ef55adc7e0c8866...	179
getmoto__moto-4853		diff --git a/moto/ec2/exceptions.py b/moto/ec2/exceptions.py --- a/moto/ec2/exceptions.py +++ b/moto/ec2/exceptions.py @@ -49,6 +49,11 @@ def __init__(self, dhcp_options_id): ) +class InvalidRequest(EC2ClientError): + def __init__(self): + super().__init__("InvalidRequest", "The request received ...	diff --git a/tests/test_ec2/test_instances.py b/tests/test_ec2/test_instances.py --- a/tests/test_ec2/test_instances.py +++ b/tests/test_ec2/test_instances.py @@ -1,4 +1,4 @@ -from botocore.exceptions import ClientError +from botocore.exceptions import ClientError, ParamValidationError import pytest from unittest i...	2022-02-11 20:45:57	EC2 run_instances BlockDeviceMapping missing support for NoDevice In [FireSim](https://fires.im/) we use an AMI that by default has two volumes. We only need one of them and thus make use of the `NoDevice` property of [`BlockDeviceMapping`](https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_BlockDeviceMapping....	getmoto/moto	2ec1a0477888d5dcc4f2cde95bc6c9502f7762d6	3.0	[ "tests/test_ec2/test_instances.py::test_modify_instance_attribute_security_groups_boto3", "tests/test_ec2/test_instances.py::test_run_instance_with_security_group_id_boto3", "tests/test_ec2/test_instances.py::test_get_instances_filtering_by_state_boto3", "tests/test_ec2/test_instances.py::test_modify_delete_o...	[ "tests/test_ec2/test_instances.py::test_run_instance_with_block_device_mappings_using_no_device" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 2ec1a0477888d5dcc4...	182
getmoto__moto-7270		diff --git a/moto/secretsmanager/exceptions.py b/moto/secretsmanager/exceptions.py --- a/moto/secretsmanager/exceptions.py +++ b/moto/secretsmanager/exceptions.py @@ -62,3 +62,10 @@ def __init__(self, message: str): class ValidationException(SecretsManagerClientError): def __init__(self, message: str): s...	diff --git a/tests/test_secretsmanager/test_list_secrets.py b/tests/test_secretsmanager/test_list_secrets.py --- a/tests/test_secretsmanager/test_list_secrets.py +++ b/tests/test_secretsmanager/test_list_secrets.py @@ -269,3 +269,13 @@ def test_with_filter_with_negation(): secret_names = list(map(lambda s: s["Na...	2024-01-29 18:33:33	Fix: Moto Doesn't Support Boto3 ListSecrets Key Filters for: 'primary-region', 'owning-service' etc. Via this section in Moto: https://github.com/getmoto/moto/blob/master/moto/secretsmanager/models.py#L29 It's clear that Moto is not currently supporting the same criteria that Boto supports for Key Filter values. Th...	getmoto/moto	496c1cd5594831bb8dcc55d5e11de7167cbf3c6f	5.0	[ "tests/test_secretsmanager/test_list_secrets.py::test_with_no_filter_values", "tests/test_secretsmanager/test_list_secrets.py::test_with_name_filter", "tests/test_secretsmanager/test_list_secrets.py::test_with_filter_with_multiple_values", "tests/test_secretsmanager/test_list_secrets.py::test_with_duplicate_f...	[ "tests/test_secretsmanager/test_secrets_duplication.py::test_replicate_secret", "tests/test_secretsmanager/test_secrets_duplication.py::test_create_secret_that_duplicates__in_same_region", "tests/test_secretsmanager/test_secrets_duplication.py::test_replicate_secret__overwrite_existing_secret", "tests/test_se...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 496c1cd5594831bb8d...	223
getmoto__moto-5189	Thanks for raising this and providing the test case, @sirrus233!	diff --git a/moto/dynamodb/parsing/expressions.py b/moto/dynamodb/parsing/expressions.py --- a/moto/dynamodb/parsing/expressions.py +++ b/moto/dynamodb/parsing/expressions.py @@ -555,6 +555,9 @@ def _parse(self): self.skip_white_space() if self.get_next_token_type() == Token.COMMA: ...	diff --git a/tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py b/tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py --- a/tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py +++ b/tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py @@ -599,3 +599,29 @@ def test_put_item_empty_set(): ...	2022-06-02 21:09:35	Moto allows syntactically invalid update expressions for DynamoDB When using the DynamoDB `UpdateItem` API, it is necessary to provide an `UpdateExpression` describing which attributes to update, and the new values. Multiple updates in the same expression are separated by commas. The real DynamoDB does not allow this e...	getmoto/moto	b96eafb3c3e4c2e40c4ca62a3b555a51296cc6e3	3.1	[ "tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py::test_query_gsi_with_wrong_key_attribute_names_throws_exception", "tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py::test_hash_key_can_only_use_equals_operations[<]", "tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py::test_creating_...	[ "tests/test_dynamodb/exceptions/test_dynamodb_exceptions.py::test_update_expression_with_trailing_comma" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff b96eafb3c3e4c2e40c...	237
getmoto__moto-5258	Thanks for raising this and providing the fix @Kostia-K!	diff --git a/moto/s3/models.py b/moto/s3/models.py --- a/moto/s3/models.py +++ b/moto/s3/models.py @@ -291,7 +291,7 @@ def response_dict(self): res["x-amz-object-lock-mode"] = self.lock_mode tags = s3_backends["global"].tagger.get_tag_dict_for_resource(self.arn) if tags: - res[...	diff --git a/tests/test_s3/test_s3_tagging.py b/tests/test_s3/test_s3_tagging.py --- a/tests/test_s3/test_s3_tagging.py +++ b/tests/test_s3/test_s3_tagging.py @@ -1,4 +1,5 @@ import boto3 +import requests import pytest import sure # noqa # pylint: disable=unused-import @@ -455,3 +456,18 @@ def test_objects_taggin...	2022-06-23 11:09:58	Tagging count in S3 response breaks requests I'm using `requests` to download a file from S3 using a presigned link. Here's example code where I expect it to print `b"abc"` but it throws an exception when calling `requests.get`. ```python import boto3 import requests from moto import mock_s3 with mock_s3(): ...	getmoto/moto	adaa7623c5554ae917c5f2900f291c44f2b8ecb5	3.1	[ "tests/test_s3/test_s3_tagging.py::test_put_object_tagging_on_both_version", "tests/test_s3/test_s3_tagging.py::test_put_object_tagging_with_single_tag", "tests/test_s3/test_s3_tagging.py::test_delete_bucket_tagging", "tests/test_s3/test_s3_tagging.py::test_get_bucket_tagging_unknown_bucket", "tests/test_s3...	[ "tests/test_s3/test_s3_tagging.py::test_generate_url_for_tagged_object" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff adaa7623c5554ae917...	268
getmoto__moto-6795	Hi @blbuford, thanks for raising this, and for the detailed repro case! > Is this as simple as dropping a one line encode/decode in the related sign/verify in the KMS backed? > It's actually even easier than that - I'll submit a PR for this shortly.	diff --git a/moto/kms/models.py b/moto/kms/models.py --- a/moto/kms/models.py +++ b/moto/kms/models.py @@ -629,9 +629,8 @@ def __ensure_valid_key_spec(self, key_spec: str) -> None: def sign( self, key_id: str, message: bytes, signing_algorithm: str ) -> Tuple[str, bytes, str]: - """Sign messag...	diff --git a/tests/test_kms/test_kms_boto3.py b/tests/test_kms/test_kms_boto3.py --- a/tests/test_kms/test_kms_boto3.py +++ b/tests/test_kms/test_kms_boto3.py @@ -1,7 +1,7 @@ import json from datetime import datetime -from cryptography.hazmat.primitives import hashes -from cryptography.hazmat.primitives.asymmetric im...	2023-09-08 21:11:12	Moto doesn't base64 decode messages before signing them Hello, we've been testing some of our KMS interactions with Moto and have run across a weird inconsistency. I've found that Moto is not base64 decoding the messages before signing them--AWS does. Its hard to notice it when you're using moto for both the sign and v...	getmoto/moto	a75e30faae06c4e8b9073b28a2cf0b8e6c4c5715	4.2	[ "tests/test_kms/test_kms_boto3.py::test__create_alias__raises_if_alias_has_restricted_characters[alias/my-alias!]", "tests/test_kms/test_kms_boto3.py::test_update_key_description", "tests/test_kms/test_kms_boto3.py::test_invalid_signing_algorithm_for_key_spec_type_ECDSA[ECC_SECG_P256K1-ECDSA_SHA_512-valid_signi...	[ "tests/test_kms/test_kms_boto3.py::test_ensure_key_can_be_verified_manually" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff a75e30faae06c4e8b9...	275
getmoto__moto-5373		diff --git a/moto/rds/models.py b/moto/rds/models.py --- a/moto/rds/models.py +++ b/moto/rds/models.py @@ -387,6 +387,8 @@ def __init__(self, **kwargs): if self.backup_retention_period is None: self.backup_retention_period = 1 self.availability_zone = kwargs.get("availability_zone") + ...	diff --git a/tests/test_rds/test_rds.py b/tests/test_rds/test_rds.py --- a/tests/test_rds/test_rds.py +++ b/tests/test_rds/test_rds.py @@ -2019,3 +2019,39 @@ def test_create_db_instance_with_tags(): resp = client.describe_db_instances(DBInstanceIdentifier=db_instance_identifier) resp["DBInstances"][0]["TagL...	2022-08-09 14:45:49	rds: `AvailabilityZone` is not printed out in `describe_db_instances` Despite being taken as an argument for `create_db_instance` (and stored in the `Database` model), the `AvailabilityZone` (`DBInstance/AvailabilityZone`) is not printed out in the: ```python rds.describe_db_instances(DBInstanceIdentifier='arn') ```...	getmoto/moto	1077c458fe36e7f2e2700afa9937cc3a0716c2ba	3.1	[ "tests/test_rds/test_rds.py::test_create_parameter_group_with_tags", "tests/test_rds/test_rds.py::test_describe_db_snapshots", "tests/test_rds/test_rds.py::test_get_non_existent_security_group", "tests/test_rds/test_rds.py::test_remove_tags_db", "tests/test_rds/test_rds.py::test_get_databases_paginated", ...	[ "tests/test_rds/test_rds.py::test_create_db_instance_without_availability_zone", "tests/test_rds/test_rds.py::test_create_db_instance_with_availability_zone" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 1077c458fe36e7f2e2...	295
getmoto__moto-5566	Thanks for raising this @nicolaei! Marking it as a bug.	diff --git a/moto/ecr/models.py b/moto/ecr/models.py --- a/moto/ecr/models.py +++ b/moto/ecr/models.py @@ -490,6 +490,11 @@ def put_image(self, repository_name, image_manifest, image_tag): else: raise Exception("{0} is not a repository".format(repository_name)) + # Tags are unique, so del...	diff --git a/tests/test_ecr/test_ecr_boto3.py b/tests/test_ecr/test_ecr_boto3.py --- a/tests/test_ecr/test_ecr_boto3.py +++ b/tests/test_ecr/test_ecr_boto3.py @@ -396,7 +396,7 @@ def test_put_image_with_push_date(): _ = client.put_image( repositoryName="test_repository", imageManifest...	2022-10-14 22:26:59	ECR implementation doesn't handle new images with the same tag correctly When uploading a new image with the same tag as an existing one, the old one doesn't get removed, resulting in two images with the same tag existing in the mock. As far as I know, docker repositories doesn't support two images with the same tag...	getmoto/moto	af318c17b9483c4102fb453e384ebd517cdcedd6	4.0	[ "tests/test_ecr/test_ecr_boto3.py::test_delete_repository_with_force", "tests/test_ecr/test_ecr_boto3.py::test_start_image_scan_error_repo_not_exists", "tests/test_ecr/test_ecr_boto3.py::test_get_lifecycle_policy", "tests/test_ecr/test_ecr_boto3.py::test_create_repository_with_non_default_config", "tests/te...	[ "tests/test_ecr/test_ecr_boto3.py::test_put_multiple_images_with_same_tag" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff af318c17b9483c4102...	340
python__mypy-14835	I noticed this today with mypy 0.942, so this is still an issue. ```shell > dmypy run Success: no issues found in 604 source files > mypy --cache-dir=/dev/null apps/matchmaking/services.py:260: error: Unused "type: ignore" comment Found 1 error in 1 file (checked 604 source files) > mypy --version mypy 0....	diff --git a/mypy/errors.py b/mypy/errors.py --- a/mypy/errors.py +++ b/mypy/errors.py @@ -668,6 +668,8 @@ def generate_unused_ignore_errors(self, file: str) -> None: False, False, False, + origin=(self.file, [line]), + target=self.target_...	diff --git a/test-data/unit/daemon.test b/test-data/unit/daemon.test --- a/test-data/unit/daemon.test +++ b/test-data/unit/daemon.test @@ -522,3 +522,92 @@ class A: x: int class B: x: int + +[case testUnusedTypeIgnorePreservedOnRerun] +-- Regression test for https://github.com/python/mypy/issues/9655 +$ dmyp...	2023-03-04T17:53:38Z	cached runs of dmypy stop reporting "unused type: ignore" warnings Using mypy 0.782, I run `dmypy run .` on my codebase. The first time it runs, it correctly reports a few ``` error: unused 'type: ignore' comment ``` same as mypy. However, when rerunning `dmypy run .`, these errors disappear, while all other er...	python/mypy	e21ddbf3ebe80bc219708a5f69a1b7d0b4e20400	1.3	[]	[ "mypy/test/testdaemon.py::DaemonSuite::daemon.test::testUnusedTypeIgnorePreservedOnRerun", "mypy/test/testdaemon.py::DaemonSuite::daemon.test::testTypeIgnoreWithoutCodePreservedOnRerun", "mypy/test/testdaemon.py::DaemonSuite::daemon.test::testTypeIgnoreWithoutCodePreservedAfterChange", "mypy/test/testdaemon.p...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e21ddbf3ebe80bc219...	349
python__mypy-10392		diff --git a/mypy/modulefinder.py b/mypy/modulefinder.py --- a/mypy/modulefinder.py +++ b/mypy/modulefinder.py @@ -627,6 +627,25 @@ def _make_abspath(path: str, root: str) -> str: return os.path.join(root, os.path.normpath(path)) +def add_py2_mypypath_entries(mypypath: List[str]) -> List[str]: + """Add ...	diff --git a/test-data/unit/check-modules.test b/test-data/unit/check-modules.test --- a/test-data/unit/check-modules.test +++ b/test-data/unit/check-modules.test @@ -2843,3 +2843,41 @@ __all__ = ['C'] [file m4.pyi] class C: pass [builtins fixtures/list.pyi] + +[case testMypyPathAndPython2Dir_python2] +# flags: --co...	2021-04-30T15:58:20Z	Look into @python2 subdirectories of mypy search path entries in Python 2 mode Typeshed uses the `@python2` subdirectory for Python 2 variants of stubs. Mypy could also support this convention for custom search paths. This would make dealing with mixed Python 2/3 codebases a little easier. If there is a user-defined...	python/mypy	322ef60ba7231bbd4f735b273e88e67afb57ad17	0.820	[ "mypy/test/testcheck.py::TypeCheckSuite::testMypyPathAndPython2Dir" ]	[ "mypy/test/testcheck.py::TypeCheckSuite::testMypyPathAndPython2Dir_python2" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 322ef60ba7231bbd4f...	352
python__mypy-9454	As a workaround for others (given to me by the experts) you can ignore this issue until it's fixed as such: ``` __path__.append(...) # type: ignore # mypy issue #1422 ``` Shouldn't be too hard to fix? If it helps a minimal reproducible example can be found below (I wrote one before discovering this issue), A pa...	diff --git a/mypy/nodes.py b/mypy/nodes.py --- a/mypy/nodes.py +++ b/mypy/nodes.py @@ -99,10 +99,11 @@ def get_column(self) -> int: implicit_module_attrs: Final = { - "__name__": "__builtins__.str", - "__doc__": None, # depends on Python version, see semanal.py - "__file__": "__builtins__.str", - "__p...	diff --git a/test-data/unit/check-incomplete-fixture.test b/test-data/unit/check-incomplete-fixture.test --- a/test-data/unit/check-incomplete-fixture.test +++ b/test-data/unit/check-incomplete-fixture.test @@ -12,14 +12,6 @@ import m m.x # E: "object" has no attribute "x" [file m.py] -[case testListMissingFromStub...	2020-09-18T05:33:58Z	Support __path__ in packages The name `__path__` is defined in packages but mypy doesn't recognize it. It seems that every `__init__.py[i]` file should have an implicit `__path__` attribute with type `List[str]`. (I encountered some code that uses `__path__` -- I didn't know about it until today.) See also: https://do...	python/mypy	2736edbbcc6273557d3e4acd5c7797dec1f7a59a	0.920	[ "mypy/test/testcheck.py::TypeCheckSuite::testDictMissingFromStubs", "mypy/test/testcheck.py::TypeCheckSuite::testReExportAllInStub" ]	[ "mypy/test/testcheck.py::TypeCheckSuite::testPackagePath" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 2736edbbcc6273557d...	367
python__mypy-15366		diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py --- a/mypy/checkexpr.py +++ b/mypy/checkexpr.py @@ -2166,15 +2166,7 @@ def check_arg( if isinstance(caller_type, DeletedType): self.msg.deleted_as_rvalue(caller_type, context) # Only non-abstract non-protocol class can be given where Type...	diff --git a/test-data/unit/check-abstract.test b/test-data/unit/check-abstract.test --- a/test-data/unit/check-abstract.test +++ b/test-data/unit/check-abstract.test @@ -196,6 +196,24 @@ x: Type[B] f(x) # OK [out] +[case testAbstractTypeInADict] +from typing import Dict, Type +from abc import abstractmethod + +cl...	2023-06-04T07:41:59Z	False-negative `type-abstract` in dictionary initialization Bug Report `type-abstract` is falsely missing when initializing a dictionary. To Reproduce ```python """False-negative `type-abstract`.""" from abc import abstractmethod class Class: @abstractmethod def method(self) -> None: ...	python/mypy	21c5439dccfc6fc21f126200b95b0552f503d5da	1.4	[ "mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testInstantiationAbstractsInTypeForAliases" ]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-abstract.test::testAbstractTypeInADict" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 21c5439dccfc6fc21f...	373
python__mypy-11966		diff --git a/mypy/plugins/dataclasses.py b/mypy/plugins/dataclasses.py --- a/mypy/plugins/dataclasses.py +++ b/mypy/plugins/dataclasses.py @@ -4,9 +4,10 @@ from typing_extensions import Final from mypy.nodes import ( - ARG_OPT, ARG_NAMED, ARG_NAMED_OPT, ARG_POS, MDEF, Argument, AssignmentStmt, CallExpr, - Con...	diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test --- a/test-data/unit/check-dataclasses.test +++ b/test-data/unit/check-dataclasses.test @@ -1522,3 +1522,17 @@ PublishedMessagesVar = dict[int, 'PublishedMessages'] class PublishedMessages: left: int [builtins fixtures/dat...	2022-01-10T18:02:34Z	Inheriting from Any with dataclass I'm importing a package at a path mypy doesn't know about and using the `--ignore-missing-imports` flag. ```python a.py import dataclasses from mypackage import MyClass # @dataclasses.dataclass # class MyClass: # bar: str @dataclasses.dataclass class Inherits(MyClass...	python/mypy	48d810d5ed25f898d4f220a7476b6b267c289b9a	0.940	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassesAnyInherit" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 48d810d5ed25f898d4...	376
python__mypy-12762	I briefly tried to make an MWE, but was unsuccessful. Looks like this is a regression between 0.942 and 0.950 This bisects to https://github.com/python/mypy/pull/12656 Okay, took another look at this and got a small repro: ``` from dataclasses import dataclass from typing import Generic, TypeVar T = TypeVar("T"...	diff --git a/mypy/plugin.py b/mypy/plugin.py --- a/mypy/plugin.py +++ b/mypy/plugin.py @@ -692,9 +692,33 @@ def get_class_decorator_hook(self, fullname: str The plugin can modify a TypeInfo _in place_ (for example add some generated methods to the symbol table). This hook is called after the class b...	diff --git a/test-data/unit/check-dataclasses.test b/test-data/unit/check-dataclasses.test --- a/test-data/unit/check-dataclasses.test +++ b/test-data/unit/check-dataclasses.test @@ -1207,7 +1207,7 @@ class A2: from dataclasses import dataclass @dataclass -class A: # E: Name "x" already defined (possibly by an imp...	2022-05-10T15:45:06Z	Crash involving dataclasses, generics, forward references Running master MyPy 0.960 on [the latest efax 1.6.3](https://github.com/NeilGirdhar/efax) gives ```shell ❯ git clone git@github.com:NeilGirdhar/efax.git ❯ cd efax ❯ mypy efax --show-traceback efax/_src/distributions/dirichlet.py:29: error: INTERNAL ERROR --...	python/mypy	e1c03ab0f37495ef4072892778ab126d04860814	0.960	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassGenericWithBound", "mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassGenericInheritanceSpecialCase2", "mypy/test/testcheck.py::TypeCheckSuite::check-dataclasses.test::testDataclassGenericInheritanceSpecialC...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e1c03ab0f37495ef40...	388
python__mypy-17016		diff --git a/mypy/plugins/attrs.py b/mypy/plugins/attrs.py --- a/mypy/plugins/attrs.py +++ b/mypy/plugins/attrs.py @@ -325,9 +325,6 @@ def attr_class_maker_callback( frozen = _get_frozen(ctx, frozen_default) order = _determine_eq_order(ctx) slots = _get_decorator_bool_argument(ctx, "slots", slots_default...	diff --git a/test-data/unit/check-incremental.test b/test-data/unit/check-incremental.test --- a/test-data/unit/check-incremental.test +++ b/test-data/unit/check-incremental.test @@ -3015,7 +3015,7 @@ class NoInit: class NoCmp: x: int -[builtins fixtures/list.pyi] +[builtins fixtures/plugin_attrs.pyi] [recheck...	2024-03-11T23:54:58Z	1.9 Regression: __hash__ method in attrs class is ignored <!-- If you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead. Please consider: - checking our common issues page: https://mypy.readthedocs.io/en/stable/common_issues.html - searching our issue trac...	python/mypy	ea49e1fa488810997d192a36d85357dadb4a7f14	1.10	[ "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testAttrsUnannotatedConverter", "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testSubclassingFrozenHashOffHashability", "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testFinalInstanceAttribute", "mypy/tes...	[ "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testSubclassEqFalseKeepsHashability", "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testSubclassingFrozenHashability", "mypy/test/testcheck.py::TypeCheckSuite::check-plugin-attrs.test::testManualOwnHashability", "mypy/test/t...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff ea49e1fa488810997d...	398
python__mypy-17256	This is reproducible without the Callable too: https://mypy-play.net/?mypy=latest&python=3.12&gist=5c01688fc2c9bd27d67d69ea6b292f94&flags=warn-unreachable ```python from typing import Literal from typing_extensions import assert_never def doit_if(result: Literal[1, -1]) -> None: if result == 1: ...	diff --git a/mypy/plugins/default.py b/mypy/plugins/default.py --- a/mypy/plugins/default.py +++ b/mypy/plugins/default.py @@ -489,7 +489,7 @@ def int_neg_callback(ctx: MethodContext, multiplier: int = -1) -> Type: return ctx.type.copy_modified( last_known_value=LiteralType( ...	diff --git a/test-data/unit/check-narrowing.test b/test-data/unit/check-narrowing.test --- a/test-data/unit/check-narrowing.test +++ b/test-data/unit/check-narrowing.test @@ -2089,3 +2089,28 @@ if isinstance(x, (Z, NoneType)): # E: Subclass of "X" and "Z" cannot exist: "Z" reveal_type(x) # E: Statement is unreac...	2024-05-17T00:03:23Z	Missing type narrowing with Literal[-1] ```python from collections.abc import Callable from typing import Literal, TypeVar, Generic from typing_extensions import assert_never T = TypeVar("T") def doit_if(t: T, fn: Callable[[T], Literal[1, -1]]) -> None: result = fn(t) if result == 1: ...	python/mypy	cdc956bd209285b43cfca712902be2da04d133f9	1.11	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testTypeNarrowingReachableNegativeUnion", "mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testTypeNarrowingReachableNegative" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff cdc956bd209285b43c...	416
python__mypy-14007	cc @ilevkivskyi	diff --git a/mypy/typeops.py b/mypy/typeops.py --- a/mypy/typeops.py +++ b/mypy/typeops.py @@ -71,13 +71,13 @@ def is_recursive_pair(s: Type, t: Type) -> bool: """ if isinstance(s, TypeAliasType) and s.is_recursive: return ( - isinstance(get_proper_type(t), Instance) + isinstanc...	diff --git a/test-data/unit/check-recursive-types.test b/test-data/unit/check-recursive-types.test --- a/test-data/unit/check-recursive-types.test +++ b/test-data/unit/check-recursive-types.test @@ -808,3 +808,21 @@ def test2() -> Tree2: def test3() -> Tree3: return 42 # E: Incompatible return value type (got "i...	2022-11-04T15:16:13Z	Crash with recursive types I just notice #731 closed and I thought giving it a go. ``` git clone git@github.com:psycopg/psycopg.git cd psycopg git reset --hard 82b84e33 python3 -m venv .venv source .venv/bin/activate pip install ./psycopg[test,dev] # Install mypy at release-0.990 pip install "git+https://g...	python/mypy	796068d06a0ab171d22f7be555c28dfad57db433	1.0	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-recursive-types.test::testRecursiveDoubleUnionNoCrash" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 796068d06a0ab171d2...	425
python__mypy-10415		diff --git a/mypy/checkexpr.py b/mypy/checkexpr.py --- a/mypy/checkexpr.py +++ b/mypy/checkexpr.py @@ -2910,9 +2910,11 @@ def visit_index_with_type(self, left_type: Type, e: IndexExpr, if isinstance(left_type, UnionType): original_type = original_type or left_type + # Don't combine li...	diff --git a/test-data/unit/check-narrowing.test b/test-data/unit/check-narrowing.test --- a/test-data/unit/check-narrowing.test +++ b/test-data/unit/check-narrowing.test @@ -1029,3 +1029,26 @@ else: reveal_type(str_or_bool_literal) # N: Revealed type is "Union[Literal[False], Literal[True]]" [builtins fixture...	2021-05-04T15:39:03Z	TypedDict narrowing regression with enum literal The following example started generating a false positive after #9097: ```py from typing import TypedDict, Literal, Union from enum import Enum class E(Enum): FOO = "a" BAR = "b" class Foo(TypedDict): tag: Literal[E.FOO] x: int class Bar...	python/mypy	b17e33fd14bb2fe3453810adf1848984e209aa59	0.820	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::testNarrowingTypedDictUsingEnumLiteral" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff b17e33fd14bb2fe345...	440
python__mypy-10478		diff --git a/mypy/semanal.py b/mypy/semanal.py --- a/mypy/semanal.py +++ b/mypy/semanal.py @@ -2295,6 +2295,11 @@ def unwrap_final(self, s: AssignmentStmt) -> bool: self.fail("Type in Final[...] can only be omitted if there is an initializer", s) else: s.type = s.unanalyzed_type.a...	diff --git a/test-data/unit/check-final.test b/test-data/unit/check-final.test --- a/test-data/unit/check-final.test +++ b/test-data/unit/check-final.test @@ -1082,3 +1082,12 @@ class A: self.x = 10 # type: Final undefined # type: ignore [builtins fixtures/tuple.pyi] + +[case testFinalUsedWithClass...	2021-05-15T18:27:46Z	Variable can be annotated with Final and ClassVar at the same time <!-- If you're new to mypy and you're not sure whether what you're experiencing is a mypy bug, please see the "Question and Help" form instead. --> Bug Report Variable can be annotated with `Final` and `ClassVar` at the same time. Bu...	python/mypy	8642b351cff94c471333256f9cd6867807384f01	0.820	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::testFinalUsedWithClassVar" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8642b351cff94c4713...	444
python__mypy-12267		diff --git a/mypy/checker.py b/mypy/checker.py --- a/mypy/checker.py +++ b/mypy/checker.py @@ -4089,36 +4089,57 @@ def visit_match_stmt(self, s: MatchStmt) -> None: if isinstance(subject_type, DeletedType): self.msg.deleted_as_rvalue(subject_type, s) + # We infer types of patt...	diff --git a/test-data/unit/check-python310.test b/test-data/unit/check-python310.test --- a/test-data/unit/check-python310.test +++ b/test-data/unit/check-python310.test @@ -1,5 +1,6 @@ -- Capture Pattern -- -[case testCapturePatternType] + +[case testMatchCapturePatternType] class A: ... m: A @@ -7,23 +8,24 @@ m...	2022-03-01T17:08:23Z	Reachability/exhaustiveness checking for match statements Currently this generates a false positive, since mypy doesn't recognize that all the possible values are processed by the match statement: ```py # Error: Missing return statement def f(x: int \| str) -> int: match x: case str(v): ret...	python/mypy	187f39461df068766a3129fa99ac376fc5a7143b	0.940	[ "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchClassPatternCaptureNamedTupleClass", "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchSimplePatternGuard", "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchAsPatternNarrows", "mypy/test/testch...	[ "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchUnionNegativeNarrowing", "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchOrPatternNarrowsStr", "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchNarrowDownUsingLiteralMatch", "mypy/test/testch...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 187f39461df068766a...	457
python__mypy-13526		diff --git a/mypy/nodes.py b/mypy/nodes.py --- a/mypy/nodes.py +++ b/mypy/nodes.py @@ -2906,7 +2906,10 @@ def protocol_members(self) -> list[str]: assert self.mro, "This property can be only accessed after MRO is (re-)calculated" for base in self.mro[:-1]: # we skip "object" since everyone implements...	diff --git a/test-data/unit/check-protocols.test b/test-data/unit/check-protocols.test --- a/test-data/unit/check-protocols.test +++ b/test-data/unit/check-protocols.test @@ -3546,3 +3546,34 @@ S = TypeVar("S") def test(arg: P[S]) -> S: ... b: Type[B] reveal_type(test(b)) # N: Revealed type is "__main__.B" + +[case...	2022-08-26T18:11:55Z	Mixing attrs.define and typing.Protocol causes INTERNAL ERROR <!-- Use this form only if mypy reports an "INTERNAL ERROR" and/or gives a traceback. Please include the traceback and all other messages below (use `mypy --show-traceback`). --> Crash Report When mixing both `typing.Protocol` and `attrs.def...	python/mypy	74e1737fd5a726f9f6fc7363660550ee5abc5f14	0.980	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testTypeAliasInProtocolBody", "mypy/test/testcheck.py::TypeCheckSuite::check-protocols.test::testTypeVarInProtocolBody" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 74e1737fd5a726f9f6...	463
python__mypy-16237	The error message is incorrect. However, mypy may not be able to type check this properly since it doesn't recognize the `len(x) == 3` check. So there seem to be two related issues: - Union types aren't recognized as iterables when type checking assignment statements. - `len(x) == n` checks can't be used to narrow down...	diff --git a/mypy/binder.py b/mypy/binder.py --- a/mypy/binder.py +++ b/mypy/binder.py @@ -12,12 +12,17 @@ from mypy.subtypes import is_same_type, is_subtype from mypy.types import ( AnyType, + Instance, NoneType, PartialType, + ProperType, + TupleType, Type, TypeOfAny, TypeType...	diff --git a/mypy/test/testcheck.py b/mypy/test/testcheck.py --- a/mypy/test/testcheck.py +++ b/mypy/test/testcheck.py @@ -126,7 +126,7 @@ def run_case_once( options = parse_options(original_program_text, testcase, incremental_step) options.use_builtins_fixtures = True if not testcase.name.en...	2023-10-08T18:26:30Z	Unpacking tuples of variable length Given the following code: ``` from typing import Any, Dict, Tuple, Union VarTuple = Union[Tuple[int, int], Tuple[int, int, int]] def make_tuple(): # type: () -> VarTuple return None x = make_tuple() a = b = c = 0 if len(x) == 3: a, b, c = x else: a, b = x c = ...	python/mypy	1c218ea2c674d7a06c8ed4c2f95855f1d3fd26da	1.7	[ "mypy/test/testcheck.py::TypeCheckSuite::check-namedtuple.test::testNamedTupleAsConditionalStrictOptionalDisabled", "mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testUnimportedHintAny", "mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testUnimportedHintAnyLower" ]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-narrowing.test::testNarrowingWithAnyOps", "mypy/test/testcheck.py::TypeCheckSuite::check-expressions.test::testStrictEqualityWithDifferentMapTypes" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 1c218ea2c674d7a06c...	505
python__mypy-15413	Thanks for posting your repro! The thing that's changed between 0.782 and 0.790 is the definition of `sorted`. `key` used to be a function that returned `Any`, but is now marked as a function that returns a `SupportsLessThan`. This makes it similar to #9590 where itertools.groupby takes a function that returns a typev...	diff --git a/mypy/checker.py b/mypy/checker.py --- a/mypy/checker.py +++ b/mypy/checker.py @@ -4270,6 +4270,7 @@ def check_return_stmt(self, s: ReturnStmt) -> None: isinstance(return_type, Instance) and return_type.type.fullname == "builtins.object" ...	diff --git a/test-data/unit/check-flags.test b/test-data/unit/check-flags.test --- a/test-data/unit/check-flags.test +++ b/test-data/unit/check-flags.test @@ -2184,3 +2184,14 @@ def f(x: bytes, y: bytearray, z: memoryview) -> None: follow_imports = skip follow_imports_for_stubs = true [builtins fixtures/dict.pyi] + ...	2023-06-11T11:27:21Z	Warn Return Any now applies to small lambdas Bug Report Suppose we have the follow code: ```python from typing import Any x: Any = [1, 2, 3] sorted([0, 2, 1], key=lambda i: x[i]) ``` With `mypy 0.790`, I get an error: ``` $ mypy --warn-return-any scratch.py scratch.py:4: error: Returning Any from fu...	python/mypy	e7b917ec7532206b996542570f4b68a33c3ff771	1.4	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-flags.test::testReturnAnyLambda" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e7b917ec7532206b99...	508
python__mypy-10572	Protocols already do (1) for incompatible types (but not for incompatible override in an explicit subclass). I think this is the most important one, (2) and (3) are also good to have, but are probably less important. I'm looking into this one If anyone wants to tackle this issue feel free to continue on my work from ht...	diff --git a/mypy/checker.py b/mypy/checker.py --- a/mypy/checker.py +++ b/mypy/checker.py @@ -1685,7 +1685,7 @@ def erase_override(t: Type) -> Type: if not emitted_msg: # Fall back to generic incompatibility message. self.msg.signature_incompatible_with_supertype( - ...	diff --git a/test-data/unit/check-abstract.test b/test-data/unit/check-abstract.test --- a/test-data/unit/check-abstract.test +++ b/test-data/unit/check-abstract.test @@ -442,9 +442,13 @@ class I(metaclass=ABCMeta): def g(self, x): pass class A(I): def f(self, x): pass - def g(self, x, y) -> None: pass \ ...	2021-06-01T16:58:47Z	Better message if method incompatible with base class Currently if a method is incompatible with a base class, mypy just tells the name of the base class but doesn't actually give more details about the expected signature. This is a problem especially if the base class is defined in typeshed, since users may not know h...	python/mypy	e07ad3b3bad14ddde2e06982eab87db104a90add	0.920	[ "mypy/test/testcheck.py::TypeCheckSuite::testOverloadErrorMessageManyMatches", "mypy/test/testcheck.py::TypeCheckSuite::testTypeGuardInAnd", "mypy/test/testcheck.py::TypeCheckSuite::testTypeTypeOverlapsWithObjectAndType", "mypy/test/testfinegrainedcache.py::FineGrainedCacheSuite::testIfMypyUnreachableClass_ca...	[ "mypy/test/testcheck.py::TypeCheckSuite::testInvalidOverrideArgumentCountWithImplicitSignature3", "mypy/test/testfinegrained.py::FineGrainedSuite::testFinalBodyReprocessedAndStillFinalOverloaded", "mypy/test/testfinegrained.py::FineGrainedSuite::testOverloadedMethodSupertype", "mypy/test/testcheck.py::TypeChe...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e07ad3b3bad14ddde2...	529
python__mypy-12048	This is a syntax error in 3.8 and later, presumably because it has no useful behavior: https://docs.python.org/3.10/whatsnew/3.8.html#changes-in-python-behavior. Perhaps mypy should just produce an error for it in any Python version. Hey! I'm relatively new to Open Source Contribution, Is there anything I could be help...	diff --git a/mypy/semanal.py b/mypy/semanal.py --- a/mypy/semanal.py +++ b/mypy/semanal.py @@ -3830,13 +3830,15 @@ def visit_star_expr(self, expr: StarExpr) -> None: expr.expr.accept(self) def visit_yield_from_expr(self, e: YieldFromExpr) -> None: - if not self.is_func_scope(): # not sure + ...	diff --git a/test-data/unit/check-semanal-error.test b/test-data/unit/check-semanal-error.test --- a/test-data/unit/check-semanal-error.test +++ b/test-data/unit/check-semanal-error.test @@ -77,10 +77,47 @@ continue # E: "continue" outside loop [case testYieldOutsideFunction] yield # E: "yield" outside function - -...	2022-01-23T22:40:12Z	crash with generator in list comprehension Crash Report possibly related to #10188 Traceback ``` mypybug.py:7: error: INTERNAL ERROR -- Please try using mypy master on Github: https://mypy.rtfd.io/en/latest/common_issues.html#using-a-development-mypy-build Please report a bug at https://github.com/...	python/mypy	6d243321d632c47b9fef5f2ad6a972f9f4b94eff	0.940	[ "mypy/test/testsemanal.py::SemAnalErrorSuite::semanal-errors.test::testYieldOutsideFunction", "mypy/test/testcheck.py::TypeCheckSuite::check-semanal-error.test::testImportFuncDup" ]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-semanal-error.test::testYieldOutsideFunction" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 6d243321d632c47b9f...	543
python__mypy-13728		diff --git a/mypy/treetransform.py b/mypy/treetransform.py --- a/mypy/treetransform.py +++ b/mypy/treetransform.py @@ -49,6 +49,7 @@ LambdaExpr, ListComprehension, ListExpr, + MatchStmt, MemberExpr, MypyFile, NamedTupleExpr, @@ -90,6 +91,17 @@ YieldExpr, YieldFromExpr, ) +fro...	diff --git a/test-data/unit/check-python310.test b/test-data/unit/check-python310.test --- a/test-data/unit/check-python310.test +++ b/test-data/unit/check-python310.test @@ -1695,3 +1695,18 @@ match input_arg: case GenericDataclass(x=a): reveal_type(a) # N: Revealed type is "builtins.str" [builtins fix...	2022-09-24T20:14:38Z	Crash on function with structural pattern matching <!-- Use this form only if mypy reports an "INTERNAL ERROR" and/or gives a traceback. Please include the traceback and all other messages below (use `mypy --show-traceback`). --> Crash Report Running mypy on the following source code results in the fol...	python/mypy	a3a5d73f7407f9565abcfd04689870e7c992f833	0.990	[]	[ "mypy/test/testcheck.py::TypeCheckSuite::check-python310.test::testMatchValueConstrainedTypeVar" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff a3a5d73f7407f9565a...	574
iterative__dvc-5822	We used to clone the repo if `rev` was provided before, nowadays we don't do that (and hope `scm` copes with that), but we don't properly initialize them. The easy fix might be to rollback to that behaviour, or fix this initialization process. Another user running into this https://discordapp.com/channels/4855868841...	diff --git a/dvc/repo/__init__.py b/dvc/repo/__init__.py --- a/dvc/repo/__init__.py +++ b/dvc/repo/__init__.py @@ -141,6 +141,7 @@ def __init__( from dvc.repo.params import Params from dvc.repo.plots import Plots from dvc.repo.stage import StageLoad + from dvc.scm import SCM f...	diff --git a/tests/func/test_api.py b/tests/func/test_api.py --- a/tests/func/test_api.py +++ b/tests/func/test_api.py @@ -182,6 +182,15 @@ def test_open_not_cached(dvc): api.read(metric_file) +def test_open_rev(tmp_dir, scm, dvc): + tmp_dir.scm_gen("foo", "foo", commit="foo") + + (tmp_dir / "foo").w...	2021-04-15T14:16:49Z	dvc.api.open: fails when using a local repo and any revision # Bug Report ## Description After upgrading to `dvc 2.0` my old code that worked fine for `dvc 1.x.x` started raising exceptions. And the reason for that is `dvc.api.open`. If I try to open any file from my local repo (you also need to provide a revisio...	iterative/dvc	31439754377d829da6babffcc720dd696554d8ab	2.0	[ "tests/func/test_api.py::test_open_scm_controlled" ]	[ "tests/func/test_api.py::test_open_rev" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 31439754377d829da6...	684
iterative__dvc-6855		diff --git a/dvc/command/machine.py b/dvc/command/machine.py --- a/dvc/command/machine.py +++ b/dvc/command/machine.py @@ -202,16 +202,32 @@ class CmdMachineStatus(CmdBase): "instance_gpu", ] + def _show_machine_status(self, name: str): + ui.write(f"machine '{name}':") + all_status = li...	diff --git a/tests/func/machine/test_machine_status.py b/tests/func/machine/test_machine_status.py --- a/tests/func/machine/test_machine_status.py +++ b/tests/func/machine/test_machine_status.py @@ -8,6 +8,7 @@ def test_status( status = machine_instance assert main(["machine", "status", "foo"]) == 0 cap ...	2021-10-24T10:08:16Z	machine: show all machines in `status` Make the `name` argument optional in `dvc machines status` so that all machines may be shown at once. Extracted from https://github.com/iterative/dvc/pull/6649#issuecomment-946940057.	iterative/dvc	3486435a7fcc76e031f7ed23335a7354441da634	2.8	[ "tests/unit/command/test_machine.py::test_create", "tests/unit/command/test_machine.py::test_ssh", "tests/unit/command/test_machine.py::test_rename", "tests/unit/command/test_machine.py::test_destroy", "tests/unit/command/test_machine.py::test_add", "tests/unit/command/test_machine.py::test_list", "test...	[ "tests/func/machine/test_machine_status.py::test_status", "tests/unit/command/test_machine.py::test_status" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 3486435a7fcc76e031...	690
iterative__dvc-5747	@lueisert Thank you for reporting the issue! I see 2 problems here: 1. The reason for failing `push`: dvc seems to not respect `remote.jobs` value: ```python def test_push(tmp_dir, scm,dvc, local_remote, mocker): from dvc.main import main tmp_dir.dvc_gen({"data": {"foo": "content"}}, commit="add data...	diff --git a/dvc/fs/base.py b/dvc/fs/base.py --- a/dvc/fs/base.py +++ b/dvc/fs/base.py @@ -38,7 +38,7 @@ class BaseFileSystem: scheme = "base" REQUIRES: ClassVar[Dict[str, str]] = {} PATH_CLS = URLInfo # type: Any - JOBS = 4 * cpu_count() + _JOBS = 4 * cpu_count() CHECKSUM_DIR_SUFFIX = ".di...	diff --git a/tests/unit/remote/test_base.py b/tests/unit/remote/test_base.py --- a/tests/unit/remote/test_base.py +++ b/tests/unit/remote/test_base.py @@ -70,7 +70,7 @@ def test_hashes_exist(object_exists, traverse, dvc): # large remote, large local object_exists.reset_mock() traverse.reset_mock() - o...	2021-03-31T12:07:28Z	push: remote.jobs in .dvc/config is ignored # Bug Report <!-- ## Issue name Issue names must follow the pattern `command: description` where the command is the dvc command that you are trying to run. The description should describe the consequence of the bug. Example: `repro: doesn't detect input changes` -...	iterative/dvc	4d4f9427d1e57fd7c3db68965e41d95d2b197339	2.0	[ "tests/unit/remote/test_base.py::test_list_paths", "tests/unit/remote/test_base.py::test_cmd_error", "tests/unit/remote/test_base.py::test_is_dir_hash[3456.dir-True]", "tests/unit/remote/test_base.py::test_is_dir_hash[3456-False]", "tests/unit/remote/test_base.py::test_list_hashes", "tests/unit/remote/tes...	[ "tests/unit/remote/test_base.py::test_list_hashes_traverse" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4d4f9427d1e57fd7c3...	700
iterative__dvc-9498	Moving this back to p1. It makes using `--pull` with any demo project or any project that uses an http filesystem impossible because the run cache is unsupported for http. Even `dvc repro --pull --no-run-cache` fails. I am guessing the answer might be "there is no longer a reason" but why is run cache not supported ...	diff --git a/dvc/repo/reproduce.py b/dvc/repo/reproduce.py --- a/dvc/repo/reproduce.py +++ b/dvc/repo/reproduce.py @@ -3,6 +3,7 @@ from dvc.exceptions import ReproductionError from dvc.repo.scm_context import scm_context +from dvc.stage.cache import RunCacheNotSupported from . import locked @@ -106,9 +107,12 @...	diff --git a/tests/func/test_repro_multistage.py b/tests/func/test_repro_multistage.py --- a/tests/func/test_repro_multistage.py +++ b/tests/func/test_repro_multistage.py @@ -9,6 +9,7 @@ from dvc.dvcfile import LOCK_FILE, PROJECT_FILE from dvc.exceptions import CyclicGraphError, ReproductionError from dvc.stage impo...	2023-05-23T14:31:30Z	`exp run --pull`: keep going even if pull fails See the conversation in https://github.com/iterative/dvc/pull/9434#issuecomment-1544466916. If `dvc exp run --pull` fails to pull anything from the cache or run-cache, the command will fail immediately. Instead, it should only show a warning and try to do as much as po...	iterative/dvc	192c9cc5770b293b9c885686d8638524c564b948	3.0	[ "tests/func/test_repro_multistage.py::test_repro_when_new_out_overlaps_others_stage_outs", "tests/func/test_repro_multistage.py::test_repro_frozen", "tests/func/test_repro_multistage.py::test_repro_list_of_commands_in_order[True]", "tests/func/test_repro_multistage.py::test_repro_list_of_commands_raise_and_st...	[ "tests/func/test_repro_multistage.py::test_repro_pulls_continue_without_run_cache", "tests/func/test_repro_multistage.py::test_repro_skip_pull_if_no_run_cache_is_passed" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 192c9cc5770b293b9c...	705
iterative__dvc-1892	Looks like it is a side effect of https://github.com/iterative/dvc/blob/0.29.0/dvc/stage.py#L423 . We should probably call `save()` on that stage if we see that it is already cached, just to ensure that all the cache is optimized. @efiop I am having problems with the work around of rm'ing the file and checking it out....	diff --git a/dvc/analytics.py b/dvc/analytics.py --- a/dvc/analytics.py +++ b/dvc/analytics.py @@ -96,11 +96,12 @@ def _read_user_id(self): with open(self.user_id_file, "r") as fobj: try: info = json.load(fobj) - return info[self.PARAM_USER_ID] - except j...	diff --git a/tests/func/test_add.py b/tests/func/test_add.py --- a/tests/func/test_add.py +++ b/tests/func/test_add.py @@ -224,9 +224,8 @@ def test_dir(self): class TestShouldUpdateStateEntryForFileAfterAdd(TestDvc): def test(self): - file_md5_counter = spy(dvc.state.file_md5) - with patch.object(...	2019-04-15T17:19:28Z	dvc add ignore unprotected files that have not been modified DVC version 0.29.0 installed via pip on Linux Following the sequence of commands dvc unprotect data.dat (modify data.dat) dvc add data.dat Correctly replaces dvc.dat with the correct kind of file link but dvc unprotect data.dat (not modifying) dv...	iterative/dvc	ee8d9a1312797071becbb9731c1abd9e066bbbfc	0.35	[ "tests/func/test_dependency.py::test_scheme[unknown://path-local]", "tests/func/test_checkout.py::TestCheckoutNotCachedFile::test", "tests/func/test_dependency.py::test_scheme[.\\file-local]", "tests/func/test_add.py::TestShouldPlaceStageInDataDirIfRepositoryBelowSymlink::test", "tests/func/test_metrics.py:...	[ "tests/unit/output/test_local.py::TestGetFilesNumber::test_return_1_on_single_file_cache", "tests/func/test_add.py::TestShouldUpdateStateEntryForDirectoryAfterAdd::test", "tests/func/test_move.py::TestMoveDirectoryShouldNotOverwriteExisting::test", "tests/func/test_checkout.py::TestCheckoutCorruptedCacheFile:...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff ee8d9a1312797071be...	720
iterative__dvc-4166	CC @pared is this expected? Considering that we have been designing `.dvcignore` to comply with `.gitignore`, I will refer to original: It seems to me that we have some disrepancies in behaviour between `git` and `dvc`. I prepared a script to illustrate that: ``` #!/bin/bash rm -rf repo mkdir repo pushd repo ...	diff --git a/dvc/ignore.py b/dvc/ignore.py --- a/dvc/ignore.py +++ b/dvc/ignore.py @@ -44,11 +44,11 @@ def __init__(self, ignore_file_path, tree): def __call__(self, root, dirs, files): files = [f for f in files if not self.matches(root, f)] - dirs = [d for d in dirs if not self.matches(root, d)]...	diff --git a/tests/func/test_ignore.py b/tests/func/test_ignore.py --- a/tests/func/test_ignore.py +++ b/tests/func/test_ignore.py @@ -173,3 +173,66 @@ def test_ignore_blank_line(tmp_dir, dvc): tmp_dir.gen(DvcIgnore.DVCIGNORE_FILE, "foo\n\ndir/ignored") assert _files_set("dir", dvc.tree) == {"dir/other"} + ...	2020-07-04T07:07:26Z	.dvcignore is broken on negation when blacklisting all ## Bug Report ### Please provide information about your setup I am not sure how far this extends to, but a lot of trials for `.dvcignore` failed when I blacklisted all and tried to whitelist some: ``` * !scripts ``` ``` * !/scripts ``` ``` /* ...	iterative/dvc	520e01f11305aba1994df354adef86e6d90180de	1.1	[ "tests/unit/test_ignore.py::test_match_ignore_from_file[path/to_ignore.txt-patterns36-False]", "tests/unit/test_ignore.py::test_match_ignore_from_file[data/file-patterns12-False]", "tests/unit/test_ignore.py::test_match_ignore_from_file[/full/path/to/ignore/file/to_ignore-patterns15-True]", "tests/unit/test_i...	[ "tests/func/test_ignore.py::test_ignore_file_in_parent_path[data_struct2-pattern_list2-result_set2]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 520e01f11305aba199...	735
iterative__dvc-1965	For the record: Another user on discord was using these configs https://discordapp.com/channels/485586884165107732/485596304961962003/573519544153538566 .	diff --git a/dvc/remote/ssh/__init__.py b/dvc/remote/ssh/__init__.py --- a/dvc/remote/ssh/__init__.py +++ b/dvc/remote/ssh/__init__.py @@ -1,5 +1,6 @@ from __future__ import unicode_literals +import os import getpass import logging @@ -38,18 +39,26 @@ def __init__(self, repo, config): parsed = urlpars...	diff --git a/tests/requirements.txt b/tests/requirements.txt --- a/tests/requirements.txt +++ b/tests/requirements.txt @@ -4,7 +4,7 @@ pytest-cov>=2.6.1 pytest-xdist>=1.26.1 pytest-mock>=1.10.4 flaky>=3.5.3 -mock>=2.0.0 +mock>=3.0.0 xmltodict>=0.11.0 awscli>=1.16.125 google-compute-engine diff --git a/tests/unit/...	2019-05-04T16:49:05Z	DVC could use the unix SSH client config files Hi, The reasoning for this feature request is: *In a team where all members uses SSH to a compute server from individual machines with individual credentials, it is sometimes normal practice to use the SSH client config file to define the host settings. See [this websit...	iterative/dvc	92cc9f7e6f19f3b92f43e28131fe50c20b297214	0.35	[ "tests/unit/remote/ssh/test_ssh.py::TestRemoteSSH::test_no_path", "tests/unit/remote/ssh/test_ssh.py::TestRemoteSSH::test_url" ]	[ "tests/unit/remote/ssh/test_ssh.py::test_ssh_user[config4-test2]", "tests/unit/remote/ssh/test_ssh.py::test_ssh_keyfile[config1-/root/.ssh/not_default.key]", "tests/unit/remote/ssh/test_ssh.py::test_ssh_port[config2-4321]", "tests/unit/remote/ssh/test_ssh.py::test_ssh_user[config5-root]", "tests/unit/remote...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 92cc9f7e6f19f3b92f...	743
iterative__dvc-6525	It seems like with some changes (see https://github.com/intake/filesystem_spec/pull/731) passes all the functional tests against HTTP. I am now moving to the phase of running benchmarks, but some early microbenchmarks indicate that as is aiohttp is not as performant as requests when it comes to the threaded code. Still...	diff --git a/dvc/fs/fsspec_wrapper.py b/dvc/fs/fsspec_wrapper.py --- a/dvc/fs/fsspec_wrapper.py +++ b/dvc/fs/fsspec_wrapper.py @@ -233,6 +233,27 @@ def find(self, path_info, detail=False, prefix=None): yield from self._strip_buckets(files, detail=detail) +# pylint: disable=arguments-differ +class NoDirecto...	diff --git a/tests/func/test_fs.py b/tests/func/test_fs.py --- a/tests/func/test_fs.py +++ b/tests/func/test_fs.py @@ -260,7 +260,6 @@ def test_fs_getsize(dvc, cloud): pytest.lazy_fixture("gs"), pytest.lazy_fixture("gdrive"), pytest.lazy_fixture("hdfs"), - pytest.lazy_fixture("http"), ...	2021-09-02T11:04:43Z	http: migrate to fsspec `http` is an important remote, and we should migrate it to fsspec. There is already a built-in http filesystem inside `fsspec`, but it seem to lack a couple of features we depend. So there should be some benchmarkings to determine whether we should create a sync, `requests` backed `httpfs` or ju...	iterative/dvc	f9bb38b96fa7dd9a6be3c1ade5a6bfd8ce6248c6	2.6	[ "tests/func/test_fs.py::test_fs_getsize[http]", "tests/func/test_fs.py::TestLocalFileSystem::test_open", "tests/func/test_fs.py::test_fs_find[webdav]", "tests/func/test_fs.py::TestLocalFileSystem::test_exists", "tests/func/test_fs.py::TestWalkInNoSCM::test_subdir", "tests/func/test_fs.py::TestLocalFileSys...	[ "tests/unit/remote/test_http.py::test_download_fails_on_error_code", "tests/unit/remote/test_http.py::test_ssl_verify_disable", "tests/unit/remote/test_http.py::test_ssl_verify_custom_cert", "tests/unit/remote/test_http.py::test_basic_auth_method", "tests/unit/remote/test_http.py::test_http_method", "test...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff f9bb38b96fa7dd9a6b...	761
iterative__dvc-4719	Reproduction script with `always_changed`: ``` #!/bin/bash rm -rf repo mkdir repo pushd repo set -ex git init --quiet dvc init --quiet echo -e "foo:\n bar: 2" > params.yaml dvc run -p params.yaml:foo.bar -n cp -o a.txt --always-changed "echo 'a' > a.txt" # not reproduced dvc repro cp ``` So ...	diff --git a/dvc/stage/cache.py b/dvc/stage/cache.py --- a/dvc/stage/cache.py +++ b/dvc/stage/cache.py @@ -3,7 +3,7 @@ import tempfile from contextlib import contextmanager -from funcy import first +from funcy import cached_property, first from voluptuous import Invalid from dvc.cache.local import _log_exceptio...	diff --git a/tests/unit/stage/test_cache.py b/tests/unit/stage/test_cache.py --- a/tests/unit/stage/test_cache.py +++ b/tests/unit/stage/test_cache.py @@ -1,5 +1,7 @@ import os +import pytest + def test_stage_cache(tmp_dir, dvc, mocker): tmp_dir.gen("dep", "dep") @@ -204,3 +206,19 @@ def _mode(path): as...	2020-10-14T11:50:56Z	Callback stage not exectued if params defined in dvc.yaml ## Bug Report Callback stages (defined by not existing dependencies as well as by `dvc run --always-changed` option) are not executed if parameters were defined in the `dvc.yaml` but restored from the run-cache and skipped. Minimal example: ``` $ git init ...	iterative/dvc	6a79111047a838b2e7daee0861570ffe01c38d02	1.8	[]	[ "tests/unit/stage/test_cache.py::test_always_changed" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 6a79111047a838b2e7...	795
iterative__dvc-5185		diff --git a/dvc/stage/cache.py b/dvc/stage/cache.py --- a/dvc/stage/cache.py +++ b/dvc/stage/cache.py @@ -34,18 +34,26 @@ def _get_cache_hash(cache, key=False): ) -def _get_stage_hash(stage): - if not (stage.cmd and stage.deps and stage.outs): - return None +def _can_hash(stage): + if stage.is_ca...	diff --git a/tests/unit/stage/test_cache.py b/tests/unit/stage/test_cache.py --- a/tests/unit/stage/test_cache.py +++ b/tests/unit/stage/test_cache.py @@ -208,14 +208,22 @@ def _mode(path): assert _mode(cache_file) == file_mode -def test_always_changed(mocker): - from dvc.repo import Repo - from dvc.stag...	2020-12-31T02:38:42Z	run-cache: `restore` does not check if stage has outs or not ```bash #! /bin/bash set -e set -x cd "$(mktemp -d)" git init && dvc init echo 'var: foo' > params.yaml # create a stage without any outputs dvc run -v -n echo -p var "echo hello world" # change `cmd` so that it's not cached # and, `-f` t...	iterative/dvc	ceaba68f629ab97905bcf365667e6f289d0617b4	1.11	[ "tests/unit/stage/test_cache.py::test_unhashable[kwargs1]", "tests/unit/stage/test_cache.py::test_unhashable[kwargs4]" ]	[ "tests/unit/stage/test_cache.py::test_unhashable[kwargs0]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff ceaba68f629ab97905...	823
iterative__dvc-5078		diff --git a/dvc/repo/experiments/executor/base.py b/dvc/repo/experiments/executor/base.py --- a/dvc/repo/experiments/executor/base.py +++ b/dvc/repo/experiments/executor/base.py @@ -376,7 +376,7 @@ def commit( logger.debug("Commit to new experiment branch '%s'", branch) scm.gitpython.repo.git.a...	diff --git a/tests/unit/scm/test_git.py b/tests/unit/scm/test_git.py --- a/tests/unit/scm/test_git.py +++ b/tests/unit/scm/test_git.py @@ -301,3 +301,23 @@ def test_ignore_remove_empty(tmp_dir, scm, git): git.ignore_remove(test_entries[1]["path"]) assert not path_to_gitignore.exists() + + +@pytest.mark.skip...	2020-12-11T04:56:32Z	experiments: commit in executor will fail if `pre-commit` or `commit-msg` hooks are enabled # Bug Report dulwich hook classes are not pickable, so if either hook is enabled you will currently get: ``` Traceback (most recent call last): File "/usr/lib64/python3.7/concurrent/futures/process.py", line 205, in _sen...	iterative/dvc	fa4bf40eb472c840db12f7e4ebcdb2716a0778f3	1.11	[ "tests/unit/scm/test_git.py::TestGit::test_belongs_to_scm_true_on_gitignore", "tests/unit/scm/test_git.py::test_remove_ref[gitpython]", "tests/unit/scm/test_git.py::test_push_refspec[False]", "tests/unit/scm/test_git.py::TestGit::test_belongs_to_scm_false", "tests/unit/scm/test_git.py::test_fetch_refspecs",...	[ "tests/unit/scm/test_git.py::test_commit_no_verify[gitpython-commit-msg]", "tests/unit/scm/test_git.py::test_commit_no_verify[dulwich-commit-msg]", "tests/unit/scm/test_git.py::test_commit_no_verify[gitpython-pre-commit]", "tests/unit/scm/test_git.py::test_commit_no_verify[dulwich-pre-commit]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff fa4bf40eb472c840db...	850
iterative__dvc-1638	Thanks for your interest in my cache permission problem, as I described here: https://discordapp.com/channels/485586884165107732/485596304961962003/547417984763691011.	diff --git a/dvc/remote/base.py b/dvc/remote/base.py --- a/dvc/remote/base.py +++ b/dvc/remote/base.py @@ -173,7 +173,21 @@ def changed(self, path_info, checksum_info): return False def save(self, path_info, checksum_info): - raise RemoteActionNotImplemented("save", self.scheme) + if path_...	diff --git a/tests/unit/remote/base.py b/tests/unit/remote/base.py --- a/tests/unit/remote/base.py +++ b/tests/unit/remote/base.py @@ -33,3 +33,29 @@ def test(self): ): with self.assertRaises(RemoteCmdError): remote_class(repo, config).remove("file") + + +class TestCac...	2019-02-19T19:34:51Z	ssh: check if cache exists when saving external outputs Right now, we are not checking if the file already exists when saving it, this would solve some issues regarding file permissions	iterative/dvc	1b703b8bc4cd3bbae306838b9d9cf01eeafe3aff	0.28	[ "tests/unit/remote/base.py::TestCmdError::test", "tests/unit/remote/base.py::TestMissingDeps::test" ]	[ "tests/unit/remote/base.py::TestCacheExists::test" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 1b703b8bc4cd3bbae3...	851
iterative__dvc-2254		diff --git a/dvc/stage.py b/dvc/stage.py --- a/dvc/stage.py +++ b/dvc/stage.py @@ -534,7 +534,11 @@ def create( if validate_state: if os.path.exists(path): - if not ignore_build_cache and stage.is_cached: + if ( + not ignore_build_cache + ...	diff --git a/tests/func/test_run.py b/tests/func/test_run.py --- a/tests/func/test_run.py +++ b/tests/func/test_run.py @@ -671,21 +671,22 @@ def test_cwd_is_ignored(self): ) -class TestRunDeterministicBase(TestDvc): - def setUp(self): - super(TestRunDeterministicBase, self).setUp() +class Determi...	2019-07-11T15:00:11Z	run: running the same command twice on a callback stage doesn't reproduce version: `0.35.7+8ef52f` ---- ```bash ❯ dvc run -o hello 'echo hello > hello' Running command: echo hello > hello Saving 'hello' to cache '.dvc/cache'. Saving information to 'hello.dvc'. ❯ dvc run -o hello 'echo hello > hello' Stage...	iterative/dvc	217f2c4dbd4b38ab465f0b8bd85b369b30734d3d	0.51	[ "tests/func/test_run.py::TestRunBadWdir::test", "tests/func/test_run.py::TestNewRunShouldRemoveOutsOnNoPersist::test", "tests/func/test_run.py::TestRunNoExec::test", "tests/func/test_run.py::TestRunBadWdir::test_same_prefix", "tests/func/test_run.py::test_run_deterministic_changed_dep", "tests/func/test_r...	[ "tests/func/test_run.py::test_run_deterministic_callback" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 217f2c4dbd4b38ab46...	853
iterative__dvc-1907	Discord context https://discordapp.com/channels/485586884165107732/485596304961962003/567370634741415936 Turns out @fgadaleta had to cd to root of repo, then problem disappeared. When fixing we should either gather metrics starting with root and not `cwd` or display some more meaningful error. @pared Clearly for `dvc m...	diff --git a/dvc/scm/git/tree.py b/dvc/scm/git/tree.py --- a/dvc/scm/git/tree.py +++ b/dvc/scm/git/tree.py @@ -109,7 +109,7 @@ def _walk( tree.abspath, ignore_file_handler=ignore_file_handler ) dirs, nondirs = dvc_ignore_filter(tree.path, dirs, nondirs) - yi...	diff --git a/tests/func/test_metrics.py b/tests/func/test_metrics.py --- a/tests/func/test_metrics.py +++ b/tests/func/test_metrics.py @@ -279,6 +279,33 @@ def test_formatted_output(self): assert expected_txt in stdout assert expected_json in stdout + def test_show_all_should_be_current_dir_agnos...	2019-04-20T02:00:55Z	dvc metrics: show metrics across branches fails with file does not exist DVC version 0.35.7 ``` dvc metrics show -a -v ERROR: failed to show metrics - 'data/data-2010-2016.h5.dvc' does not exist. ------------------------------------------------------------ Traceback (most recent call last): File "/Users/frag...	iterative/dvc	8ef52f92ee262bdc76b24955c72a5df18b6eb1a5	0.35	[ "tests/func/test_tree.py::TestWorkingTree::test_isdir", "tests/func/test_metrics.py::TestMetricsRecursive::test", "tests/func/test_metrics.py::TestMetrics::test_formatted_output", "tests/func/test_metrics.py::TestMetrics::test_xpath_is_none", "tests/func/test_metrics.py::TestMetricsType::test_show", "test...	[ "tests/func/test_tree.py::TestWalkInGit::test_nobranch", "tests/func/test_tree.py::TestWalkInGit::test_branch", "tests/func/test_metrics.py::TestMetricsCLI::test_show_all_should_be_current_dir_agnostic", "tests/func/test_tree.py::TestWalkInNoSCM::test_subdir", "tests/func/test_metrics.py::TestMetrics::test_...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8ef52f92ee262bdc76...	857
iterative__dvc-4190	For the record: the issue is that in external repo we operate on virtual trees(we don't checkout to the branch), but we still read config through regular open() calls, which is causing this issue. Need to make our config use repo's `self.tree` to read/write configs.	diff --git a/dvc/config.py b/dvc/config.py --- a/dvc/config.py +++ b/dvc/config.py @@ -232,8 +232,10 @@ class Config(dict): CONFIG_LOCAL = "config.local" def __init__( - self, dvc_dir=None, validate=True + self, dvc_dir=None, validate=True, tree=None, ): # pylint: disable=super-init-not-...	diff --git a/tests/unit/repo/test_repo.py b/tests/unit/repo/test_repo.py --- a/tests/unit/repo/test_repo.py +++ b/tests/unit/repo/test_repo.py @@ -3,7 +3,8 @@ import pytest from funcy import raiser -from dvc.repo import locked +from dvc.repo import NotDvcRepoError, Repo, locked +from dvc.utils.fs import remove ...	2020-07-10T21:11:36Z	dvc get --rev doesn't work if master is not a dvc repo ## Bug Report ### Please provide information about your setup Output of `dvc version`: ```console DVC version: 1.1.7 Python version: 3.7.2 Platform: Darwin-18.7.0-x86_64-i386-64bit Binary: False Package: pip Supported remotes: http, https, s3 Ca...	iterative/dvc	375998c6642c3003aebcf6b25e69360e7cf6f105	1.1	[ "tests/unit/repo/test_repo.py::test_skip_graph_checks", "tests/unit/repo/test_repo.py::test_is_dvc_internal", "tests/unit/repo/test_repo.py::test_locked" ]	[ "tests/unit/repo/test_repo.py::test_branch_config" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 375998c6642c3003ae...	859
iterative__dvc-3726	Hi @nik123 ! `status` never had `-R` flag. We need to introduce it. All logic is there, we would simply need to add it to `dvc/command/status.py` and `dvc/repo/status.py`, that would then pass it to `collect` and `used_cache` in `dvc/repo/status.py`, similar how push/pull/fetch/etc do that.	diff --git a/dvc/command/data_sync.py b/dvc/command/data_sync.py --- a/dvc/command/data_sync.py +++ b/dvc/command/data_sync.py @@ -334,4 +334,12 @@ def add_parser(subparsers, _parent_parser): default=False, help="Show status for all dependencies of the specified target.", ) + status_parser.add...	diff --git a/tests/func/test_status.py b/tests/func/test_status.py --- a/tests/func/test_status.py +++ b/tests/func/test_status.py @@ -93,3 +93,23 @@ def test_status_on_pipeline_stages(tmp_dir, dvc, run_copy): "changed command", ], } + + +def test_status_recursive(tmp_dir, dvc): + tmp_dir....	2020-05-03T17:16:27Z	status: add --recursive flag For some reason `dvc status` doesn't have `-R` flag in v 0.93.	iterative/dvc	4e9b38970a56e0f994ca6f6b44f1b1f550163e73	0.93	[ "tests/func/test_status.py::TestStatus::test_implied_cloud" ]	[ "tests/unit/command/test_status.py::test_cloud_status" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4e9b38970a56e0f994...	875
iterative__dvc-8177	Thanks @mattseddon! Could you describe how it impacts VS Code and how important it is? I see that it's inconsistent with other commands, but both behaviors seem initially reasonable to me, and since I have never seen a user complaint about it, I would only prioritize it based on your needs. This broke the workflow o...	diff --git a/dvc/commands/experiments/diff.py b/dvc/commands/experiments/diff.py --- a/dvc/commands/experiments/diff.py +++ b/dvc/commands/experiments/diff.py @@ -27,7 +27,7 @@ def run(self): if self.args.json: ui.write_json(diff) - else: + elif diff: from dvc.compare ...	diff --git a/tests/func/experiments/test_diff.py b/tests/func/experiments/test_diff.py --- a/tests/func/experiments/test_diff.py +++ b/tests/func/experiments/test_diff.py @@ -1,6 +1,17 @@ from funcy import first +def test_diff_no_commits(tmp_dir): + from scmrepo.git import Git + + from dvc.repo import Repo +...	2022-08-25T08:17:52Z	`plots diff` & `exp show`: unexpected error - Empty git repo # Bug Report <!-- ## Issue name Issue names must follow the pattern `command: description` where the command is the dvc command that you are trying to run. The description should describe the consequence of the bug. Example: `repro: doesn't detect ...	iterative/dvc	e815bbe211ac931e816435a0a90127141223d2a2	2.20	[ "tests/func/experiments/test_diff.py::test_diff_no_commits" ]	[ "tests/func/experiments/test_show.py::test_show_no_commits", "tests/func/plots/test_diff.py::test_no_commits" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e815bbe211ac931e81...	882
iterative__dvc-5732	We should provide this option, but it's better if user explicitly provided their custom certs via (`AWS_CA_BUNDLE`) (need to check though if it really works). I think both options complement each other, don't see any contradiction. The same as boto probably supports both, as far as I understand. Do you have any specifi...	diff --git a/dvc/config_schema.py b/dvc/config_schema.py --- a/dvc/config_schema.py +++ b/dvc/config_schema.py @@ -145,6 +145,7 @@ class RelPath(str): "session_token": str, Optional("listobjects", default=False): Bool, # obsoleted Optional("use_ssl", defau...	diff --git a/tests/unit/fs/test_s3.py b/tests/unit/fs/test_s3.py --- a/tests/unit/fs/test_s3.py +++ b/tests/unit/fs/test_s3.py @@ -29,6 +29,22 @@ def test_init(dvc): assert fs.path_info == url +def test_verify_ssl_default_param(dvc): + config = { + "url": url, + } + fs = S3FileSystem(dvc, confi...	2021-03-30T14:00:33Z	s3 and compatible: add a config option to support validate_certs Similar to use_ssl, we should probably provide a config for this. More context here - https://discordapp.com/channels/485586884165107732/485596304961962003/685129104214851595	iterative/dvc	4d4f9427d1e57fd7c3db68965e41d95d2b197339	2.0	[ "tests/unit/fs/test_s3.py::test_get_s3_connection_error", "tests/unit/fs/test_s3.py::test_grants_mutually_exclusive_acl_error", "tests/unit/fs/test_s3.py::test_get_bucket", "tests/unit/fs/test_s3.py::test_get_s3_no_credentials", "tests/unit/fs/test_s3.py::test_grants", "tests/unit/fs/test_s3.py::test_sse_...	[ "tests/unit/fs/test_s3.py::test_verify_ssl_default_param", "tests/unit/fs/test_s3.py::test_ssl_verify_bool_param" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4d4f9427d1e57fd7c3...	889
pydantic__pydantic-9053		diff --git a/pydantic/fields.py b/pydantic/fields.py --- a/pydantic/fields.py +++ b/pydantic/fields.py @@ -64,7 +64,7 @@ class _FromFieldInfoInputs(typing_extensions.TypedDict, total=False): strict: bool \| None min_length: int \| None max_length: int \| None - pattern: str \| None + pattern: str \| typ...	diff --git a/tests/test_types.py b/tests/test_types.py --- a/tests/test_types.py +++ b/tests/test_types.py @@ -3936,6 +3936,59 @@ class Foobar(BaseModel): } +@pytest.mark.parametrize( + 'use_field', + [pytest.param(True, id='Field'), pytest.param(False, id='constr')], +) +def test_compiled_pattern_in_fie...	2024-03-19T15:51:37Z	Add support `re.Pattern[str]` to `pattern` field in `Field` ### Initial Checks - [X] I have searched Google & GitHub for similar requests and couldn't find anything - [X] I have read and followed [the docs](https://docs.pydantic.dev) and still think this feature is missing ### Description I think it just a simple id...	pydantic/pydantic	ac9e6ee3e40845014fc2f9c79d95c5896dc3eca7	2.7	[ "tests/test_types.py::test_finite_float_validation_error[inf]", "tests/test_types.py::test_default_validators[date_check-value113-result113]", "tests/test_types.py::test_decimal_validation[condecimal-type_args46-value46-result46]", "tests/test_types.py::test_types_repr[PastDate-PastDate]", "tests/test_types...	[ "tests/test_types.py::test_compiled_pattern_in_field[Field]", "tests/test_types.py::test_compiled_pattern_in_field[constr]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff ac9e6ee3e40845014f...	1,045
pydantic__pydantic-8500	@piercsi, Thanks for bringing this to our attention. We'll roll out a fix for this with `2.6.0` :).	diff --git a/pydantic/main.py b/pydantic/main.py --- a/pydantic/main.py +++ b/pydantic/main.py @@ -212,17 +212,19 @@ def model_construct(cls: type[Model], _fields_set: set[str] \| None = None, **val """ m = cls.__new__(cls) fields_values: dict[str, Any] = {} - defaults: dict[str, Any] =...	diff --git a/tests/test_construction.py b/tests/test_construction.py --- a/tests/test_construction.py +++ b/tests/test_construction.py @@ -509,3 +509,13 @@ class Model(BaseModel): m = Model.model_construct(x=1, y=2) assert m.__pydantic_extra__ == {'y': 2} + + +def test_retain_order_of_fields(): + class M...	2024-01-05T15:53:28Z	Model order not maintained when serializing after using model_construct with default values ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description When using `model_construct()` with default values, any fields with defaults are "moved" the top of the output when using `model_dump()` ### Examp...	pydantic/pydantic	069d0205424f98912f8b670b1bc5cfc7df37b2f3	2.6	[ "tests/test_construction.py::test_copy_deep_extra[copy]", "tests/test_construction.py::test_construct_default_factory", "tests/test_construction.py::test_construct_misuse", "tests/test_construction.py::test_simple_copy[model_copy]", "tests/test_construction.py::test_immutable_copy_with_frozen[copy]", "tes...	[ "tests/test_construction.py::test_retain_order_of_fields" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 069d0205424f98912f...	1,049
pydantic__pydantic-9137	@jkugler, Seems like a reasonable feature request 👍. I think we should still stick with `True` and `False` as the allowed settings, but we could support `Field(..., coerce_numbers_to_str=True)` or something along those lines. Seems perfectly reasonable. I'm a Pydantic newbie thrown in the deep end by migrating a pr...	diff --git a/pydantic/_internal/_known_annotated_metadata.py b/pydantic/_internal/_known_annotated_metadata.py --- a/pydantic/_internal/_known_annotated_metadata.py +++ b/pydantic/_internal/_known_annotated_metadata.py @@ -19,7 +19,15 @@ INEQUALITY = {'le', 'ge', 'lt', 'gt'} NUMERIC_CONSTRAINTS = {'multiple_of', 'all...	diff --git a/tests/test_fields.py b/tests/test_fields.py --- a/tests/test_fields.py +++ b/tests/test_fields.py @@ -144,3 +144,29 @@ def prop_field(self): with pytest.raises(AttributeError, match=f"'{Model.__name__}' object has no attribute 'invalid_field'"): Model().invalid_field + + +@pytest.mark.param...	2024-03-29T21:43:15Z	coerce_numbers_to_str needs a per-field variant ### Initial Checks - [X] I have searched Google & GitHub for similar requests and couldn't find anything - [X] I have read and followed [the docs](https://docs.pydantic.dev) and still think this feature is missing ### Description We are migrating our code from Pydantic...	pydantic/pydantic	932b025f892c5bbfa0a5da0d671179da7f93666e	2.7	[ "tests/test_fields.py::test_init_var_field", "tests/test_fields.py::test_field_info_annotation_keyword_argument", "tests/test_fields.py::test_field_info_annotated_attribute_name_clashing", "tests/test_fields.py::test_root_model_arbitrary_field_name_error", "tests/test_fields.py::test_root_model_field_overri...	[ "tests/test_fields.py::test_coerce_numbers_to_str_field_precedence[11.11]", "tests/test_fields.py::test_coerce_numbers_to_str_field_precedence[42]", "tests/test_fields.py::test_coerce_numbers_to_str_field_option[443]", "tests/test_fields.py::test_coerce_numbers_to_str_field_precedence[443]", "tests/test_fie...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 932b025f892c5bbfa0...	1,055
pydantic__pydantic-8920	@vaultah, Yep, looks like a bug. Thanks for reporting the regression. You're welcome to submit a PR with a fix, if you'd like. I'll add this to the 2.7 milestone! @sydney-runkle I can try and look into this if it's still available 😄 @NeevCohen, For sure! Go for it! Ok, I think I found the source of the problem....	diff --git a/pydantic/_internal/_std_types_schema.py b/pydantic/_internal/_std_types_schema.py --- a/pydantic/_internal/_std_types_schema.py +++ b/pydantic/_internal/_std_types_schema.py @@ -81,8 +81,6 @@ def get_json_schema(_, handler: GetJsonSchemaHandler) -> JsonSchemaValue: # so that we can still generate ...	diff --git a/tests/test_types.py b/tests/test_types.py --- a/tests/test_types.py +++ b/tests/test_types.py @@ -6410,3 +6410,22 @@ def test_on_error_omit_top_level() -> None: # if it hits the top level, but this documents the current behavior at least with pytest.raises(SchemaError, match='Uncaught Omit error'...	2024-02-29T19:14:18Z	use_enum_values=True has no effect if another model with the same enum has use_enum_values=False ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description If two separate models with different `use_enum_values` settings both have fields with the same enum, pydantic v2 doesn't use that enum'...	pydantic/pydantic	0eb31fce2c21fd8f93040caf3bbfce51e37421d5	2.7	[ "tests/test_types.py::test_finite_float_validation_error[inf]", "tests/test_types.py::test_default_validators[date_check-value113-result113]", "tests/test_types.py::test_decimal_validation[condecimal-type_args46-value46-result46]", "tests/test_types.py::test_types_repr[PastDate-PastDate]", "tests/test_types...	[ "tests/test_types.py::test_diff_enums_diff_configs" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 0eb31fce2c21fd8f93...	1,057
pydantic__pydantic-5390	Great catch! We'll let you know once this has been addressed.	diff --git a/pydantic/_internal/_decorators.py b/pydantic/_internal/_decorators.py --- a/pydantic/_internal/_decorators.py +++ b/pydantic/_internal/_decorators.py @@ -237,9 +237,11 @@ def __get__(self, obj: object, objtype: type[object]) -> Callable[..., ReturnTyp def __get__( self, obj: object \| None, ob...	diff --git a/tests/test_json.py b/tests/test_json.py --- a/tests/test_json.py +++ b/tests/test_json.py @@ -233,22 +233,6 @@ def serialize_timedt(self, _v: timedelta, _info): assert Child().model_dump_json() == '{"dt":"parent_encoder","timedt":"child_encoder"}' -def test_json_encoder_inheritance_override(): - ...	2023-04-05T22:06:47Z	`root_validator` methods are not called with subclasses as the first argument (always have the cls on which they were defined) ### Initial Checks - [X] I confirm that I'm using Pydantic V2 installed directly from the `main` branch, or equivalent ### Description I believe functions decorated `root_validator` ar...	pydantic/pydantic	28e83965098c52536af2beb54dcd4da777a4fcd2	2.01	[ "tests/test_validators.py::test_v1_validator_signature_kwargs1", "tests/test_json.py::test_json_serialization[ser_type21-<lambda>-[0,1,2,3]]", "tests/test_json.py::test_json_serialization[Color-<lambda>-\"black\"]", "tests/test_validators.py::test_field_that_is_being_validated_is_excluded_from_validator_value...	[ "tests/test_validators.py::test_root_validator_subclass", "tests/test_serialize.py::test_serializer_allow_reuse_inheritance_override", "tests/test_validators.py::test_invalid_field" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 28e83965098c52536a...	1,063
pydantic__pydantic-5021		diff --git a/pydantic/_internal/_model_construction.py b/pydantic/_internal/_model_construction.py --- a/pydantic/_internal/_model_construction.py +++ b/pydantic/_internal/_model_construction.py @@ -144,10 +144,18 @@ def complete_model_class( except PydanticUndefinedAnnotation as e: if raise_errors: ...	diff --git a/tests/test_forward_ref.py b/tests/test_forward_ref.py --- a/tests/test_forward_ref.py +++ b/tests/test_forward_ref.py @@ -64,7 +64,7 @@ class Bar(BaseModel): 'FieldInfo(annotation=SelfType, required=False, metadata=[SchemaRef(__pydantic_core_schema__' ) # but Foo is not ready to use - ...	2023-02-06T23:55:28Z	Show clearer error message in the event of undefined annotations (v2) Currently, if you include a forward reference _without_ setting the config field `undefined_types_warning = True`, it is difficult to understand what is happening: ```python from typing import Optional from pydantic import BaseModel class M...	pydantic/pydantic	ef3cc495a9c86553b62a95a6052fd9b6ebc045e9	2.0	[ "tests/test_forward_ref.py::test_self_forward_ref_module", "tests/test_forward_ref.py::test_self_forward_ref_local", "tests/test_forward_ref.py::test_undefined_types_warning_1b_suppressed_via_config_2b_forward_ref", "tests/test_forward_ref.py::test_postponed_annotations_auto_model_rebuild", "tests/test_forw...	[ "tests/test_forward_ref.py::test_undefined_types_warning_raised_by_usage", "tests/test_forward_ref.py::test_undefined_types_warning_1a_raised_by_default_2a_future_annotations", "tests/test_forward_ref.py::test_undefined_types_warning_1a_raised_by_default_2b_forward_ref", "tests/test_forward_ref.py::test_forwa...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff ef3cc495a9c86553b6...	1,067
pydantic__pydantic-8027	Running ```py import pydantic print(pydantic.__version__) print(pydantic.dataclasses.__name__) # dataclasses import pydantic.dataclasses print(pydantic.dataclasses.__name__) # pydantic.dataclasses ``` Gives me: ``` 2.4.2 pydantic.dataclasses pydantic.dataclasses ``` ??? Are you using the release...	diff --git a/pydantic/__init__.py b/pydantic/__init__.py --- a/pydantic/__init__.py +++ b/pydantic/__init__.py @@ -365,7 +365,7 @@ def __getattr__(attr_name: str) -> object: from importlib import import_module if module_name == '__module__': - return import_module(attr_name, package=package) + ...	diff --git a/tests/conftest.py b/tests/conftest.py --- a/tests/conftest.py +++ b/tests/conftest.py @@ -3,9 +3,11 @@ import os import re import secrets +import subprocess import sys import textwrap from dataclasses import dataclass +from pathlib import Path from types import FunctionType from typing import Any, ...	2023-11-06T18:04:05Z	Using `pydantic.dataclasses` after only importing `pydantic` gives the stdlib `dataclasses` module ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description Code like this is wrong in a confusing way: ```python import pydantic @pydantic.dataclasses.dataclass class ... ``` I ran into t...	pydantic/pydantic	cde3779c602406ef6c41d33fce44092bb8c5b315	2.4	[ "tests/test_migration.py::test_removed_on_v2[pydantic.typing:is_union]", "tests/test_migration.py::test_moved_on_v2[pydantic.utils:to_lower_camel]", "tests/test_migration.py::test_moved_but_not_warn_on_v2[pydantic.class_validators:validator]", "tests/test_exports.py::test_public_api_dynamic_imports[model_seri...	[ "tests/test_exports.py::test_dataclass_import", "tests/test_migration.py::test_getattr_migration" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff cde3779c602406ef6c...	1,073
pydantic__pydantic-5897		diff --git a/pydantic/_internal/_model_construction.py b/pydantic/_internal/_model_construction.py --- a/pydantic/_internal/_model_construction.py +++ b/pydantic/_internal/_model_construction.py @@ -551,5 +551,7 @@ def model_private_delattr(self: BaseModel, item: str) -> Any: del self.__pydantic_private__[...	diff --git a/tests/test_create_model.py b/tests/test_create_model.py --- a/tests/test_create_model.py +++ b/tests/test_create_model.py @@ -1,3 +1,4 @@ +import platform from typing import Optional, Tuple import pytest @@ -360,6 +361,72 @@ class Model(BaseModel): assert Model()._private_attr == 2 +def test_d...	2023-05-27T13:32:40Z	Error on deleting an attribute of a Model having a PrivateAttr defined ### Initial Checks - [X] I confirm that I'm using Pydantic V2 installed directly from the `main` branch, or equivalent ### Description If a Model has a `PrivateAttr` defined deleting a regular field of its instance results in an `AttributeError`....	pydantic/pydantic	742c39150f3bcd695420ce5a631e36cc365164f1	2.04	[ "tests/test_create_model.py::test_private_attr_set_name_do_not_crash_if_not_callable", "tests/test_create_model.py::test_create_model_protected_namespace_default", "tests/test_create_model.py::test_del_model_attr_error", "tests/test_create_model.py::test_config_and_base", "tests/test_create_model.py::test_c...	[ "tests/test_create_model.py::test_del_model_attr_with_privat_attrs" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 742c39150f3bcd6954...	1,075
pydantic__pydantic-8567	@Anvil, Thanks for reporting this. This does look like a bug 🐛. We'll work on a fix for this unexpected behavior 👍. Thank you for your reply. I've conducted a little experiment, that you might consider interesting: ```python import json from itertools import combinations, chain, permutations from typing ...	diff --git a/pydantic/functional_validators.py b/pydantic/functional_validators.py --- a/pydantic/functional_validators.py +++ b/pydantic/functional_validators.py @@ -153,13 +153,17 @@ class Model(BaseModel): func: core_schema.NoInfoValidatorFunction \| core_schema.WithInfoValidatorFunction def __get_pydanti...	diff --git a/tests/test_validators.py b/tests/test_validators.py --- a/tests/test_validators.py +++ b/tests/test_validators.py @@ -20,6 +20,7 @@ ConfigDict, Field, GetCoreSchemaHandler, + PlainSerializer, PydanticDeprecatedSince20, PydanticUserError, TypeAdapter, @@ -2810,3 +2811,19 @@ ...	2024-01-16T20:23:59Z	Annotated type PlainSerializer not used if placed before PlainValidator ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description Dear pydantic maintainers and community. Thank you very much for your time, your code and the documentation that comes along. All of them are very useful to me. ...	pydantic/pydantic	8060fa1cff965850e5e08a67ca73d5272dcdcf9f	2.6	[ "tests/test_validators.py::test_v1_validator_signature_kwargs1", "tests/test_validators.py::test_field_that_is_being_validated_is_excluded_from_validator_values", "tests/test_validators.py::test_validator_self", "tests/test_validators.py::test_validator_bad_fields_throws_configerror", "tests/test_validators...	[ "tests/test_validators.py::test_plain_validator_plain_serializer" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8060fa1cff965850e5...	1,076
pydantic__pydantic-5874	> make sure valididators are working on vanilla dataclasses as fields They are, not sure what you meant by this. > make sure kw_only is correctly inherited I believe this works, here's a quick test. Is there something specific that wasn't working? ```python from pydantic.dataclasses import dataclass @...	diff --git a/pydantic/_internal/_dataclasses.py b/pydantic/_internal/_dataclasses.py --- a/pydantic/_internal/_dataclasses.py +++ b/pydantic/_internal/_dataclasses.py @@ -174,7 +174,7 @@ class B(A): def is_pydantic_dataclass(_cls: type[Any]) -> TypeGuard[type[PydanticDataclass]]: - return dataclasses.is_datacla...	diff --git a/tests/test_dataclasses.py b/tests/test_dataclasses.py --- a/tests/test_dataclasses.py +++ b/tests/test_dataclasses.py @@ -22,6 +22,7 @@ PydanticUserError, TypeAdapter, ValidationError, + field_serializer, field_validator, ) from pydantic._internal._model_construction import MockVal...	2023-05-25T23:29:35Z	V2 dataclass improvements * make sure valididators are working on vanilla dataclasses as fields * make sure `kw_only` is correctly inherited * make sure serialization schema is right Fix ```py from datetime import datetime from pydantic import field_validator from pydantic.dataclasses import dataclass ...	pydantic/pydantic	db73d38047f79b8f67e2fd68be302ff9f3487c20	2.04	[ "tests/test_dataclasses.py::test_dataclass_equality_for_field_values[pydantic_pydantic]", "tests/test_dataclasses.py::test_validate_assignment_extra_unknown_field_assigned_errors[config2]", "tests/test_dataclasses.py::test_allow_extra", "tests/test_dataclasses.py::test_validate_assignment", "tests/test_data...	[ "tests/test_dataclasses.py::test_decorators_in_model_field[stdlib-pydantic]", "tests/test_dataclasses.py::test_decorators_in_model_field[stdlib-combined]", "tests/test_dataclasses.py::test_vanilla_dataclass_decorators_in_type_adapter[stdlib-combined]", "tests/test_dataclasses.py::test_vanilla_dataclass_decora...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff db73d38047f79b8f67...	1,078
pydantic__pydantic-5529	I think the plan is to create a new validator called `@model_validator` or similar, which will be like `@root_validator` but follow more of the v2 api conventions (and, in particular, have `context`). And `@root_validator` will get deprecated and just remain for v1 backwards compatibility. @adriangb may have more de...	diff --git a/pydantic/_internal/_decorators.py b/pydantic/_internal/_decorators.py --- a/pydantic/_internal/_decorators.py +++ b/pydantic/_internal/_decorators.py @@ -248,6 +248,7 @@ def build(model_dc: type[Any]) -> DecoratorInfos: # noqa: C901 (ignore complexi res.root_validator.update({k: v.bind_to...	diff --git a/tests/test_model_validator.py b/tests/test_model_validator.py --- a/tests/test_model_validator.py +++ b/tests/test_model_validator.py @@ -2,6 +2,8 @@ from typing import Any, Dict, cast +import pytest + from pydantic import BaseModel, ValidationInfo from pydantic.decorators import ModelWrapValidatorH...	2023-04-19T15:36:38Z	root_validator and context So in v2 `@field_validator` have context passed to a callback but `@root_validator` is not can we add as well context to `@root_validator` ?	pydantic/pydantic	8ee553aae909a88df483d6454ed9af58c494879f	2.02	[ "tests/test_model_validator.py::test_model_validator_after", "tests/test_model_validator.py::test_model_validator_wrap", "tests/test_model_validator.py::test_model_validator_before[classmethod]" ]	[ "tests/test_model_validator.py::test_model_validator_before[<lambda>]", "tests/test_model_validator.py::test_subclass" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8ee553aae909a88df4...	1,080
pydantic__pydantic-5591	Hi @tobinus I don't understand. If you want raw enums, then you should use raw enum as value hence write ```python print(type(Meal(dessert={'kind': DessertTypes.CAKE}).dessert).__name__) # Cake ``` which works instead of ```python print(type(Meal(dessert={'kind': 'cake'}).dessert).__name__) # ValidationError...	diff --git a/pydantic/_internal/_std_types_schema.py b/pydantic/_internal/_std_types_schema.py --- a/pydantic/_internal/_std_types_schema.py +++ b/pydantic/_internal/_std_types_schema.py @@ -13,11 +13,11 @@ from enum import Enum from ipaddress import IPv4Address, IPv4Interface, IPv4Network, IPv6Address, IPv6Interface...	diff --git a/tests/test_construction.py b/tests/test_construction.py --- a/tests/test_construction.py +++ b/tests/test_construction.py @@ -37,13 +37,16 @@ def test_construct_fields_set(): assert m.model_dump() == {'a': 3, 'b': -1} -def test_construct_allow_extra(): - """model_construct() should allow extra ...	2023-04-25T22:58:54Z	Support implicit casting for enum members in Literal ### Checks * [x] I added a descriptive title to this issue * [x] I have searched (google, github) for similar issues ~and couldn't find anything~ * [x] I have read and followed [the docs](https://pydantic-docs.helpmanual.io/) and still think this feature/change ...	pydantic/pydantic	f50ae9f282c29e460563829d40d9eeffcf87e479	2.03	[ "tests/test_types.py::test_finite_float_validation_error[inf]", "tests/test_types.py::test_default_validators[date_check-value113-result113]", "tests/test_construction.py::test_construct_misuse", "tests/test_construction.py::test_simple_copy[copy]", "tests/test_types.py::test_default_validators[date_check-v...	[ "tests/test_types.py::test_plain_enum_validate" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff f50ae9f282c29e4605...	1,090
pydantic__pydantic-5362	please can you check this is fixed, see #5126 for some context. I don't believe this is currently resolved, but I will just point out that in most places where `.__qualname__` is accessed directly, it seems to me that either `pydantic._internal._core_utils.get_type_ref` or something very similar could be used instead. ...	diff --git a/pydantic/_internal/_decorators.py b/pydantic/_internal/_decorators.py --- a/pydantic/_internal/_decorators.py +++ b/pydantic/_internal/_decorators.py @@ -4,6 +4,7 @@ from __future__ import annotations as _annotations import warnings +from functools import partial, partialmethod from inspect import Par...	diff --git a/tests/test_serialize.py b/tests/test_serialize.py --- a/tests/test_serialize.py +++ b/tests/test_serialize.py @@ -1,6 +1,7 @@ """ New tests for v2 of serialization logic. """ +from functools import partial, partialmethod from typing import Any, Optional import pytest @@ -18,6 +19,16 @@ ) +@pyte...	2023-04-04T13:40:36Z	Remove requirement that callables have `__qualname__` attribute	pydantic/pydantic	0cd57b3e0c75d9622012de542e5ddc110fe55743	2.01	[ "tests/test_validators.py::test_v1_validator_signature_kwargs1", "tests/test_validators.py::test_field_that_is_being_validated_is_excluded_from_validator_values", "tests/test_serialize.py::test_serialize_decorator_self_no_info", "tests/test_validators.py::test_validator_self", "tests/test_serialize.py::test...	[ "tests/test_validators.py::test_functools_partial_validator_v1[partial_val_func2]", "tests/test_validators.py::test_duplicates", "tests/test_serialize.py::test_serialize_partial[int_ser_instance_method_with_info2]", "tests/test_validators.py::test_functools_partialmethod_validator_v2_cls_method[partial_cls_va...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 0cd57b3e0c75d96220...	1,094
pydantic__pydantic-5587		diff --git a/pydantic/fields.py b/pydantic/fields.py --- a/pydantic/fields.py +++ b/pydantic/fields.py @@ -113,7 +113,7 @@ def __init__(self, **kwargs: Any) -> None: self.default_factory = kwargs.get('default_factory') if self.default is not Undefined and self.default_factory is not None: - ...	diff --git a/tests/test_main.py b/tests/test_main.py --- a/tests/test_main.py +++ b/tests/test_main.py @@ -1376,7 +1376,7 @@ class MyModel(BaseModel): def test_two_defaults(): - with pytest.raises(ValueError, match='^cannot specify both default and default_factory$'): + with pytest.raises(TypeError, match='^...	2023-04-25T20:31:56Z	ModelField and ModelPrivateAttr should raise TypeError as per https://github.com/samuelcolvin/pydantic/pull/2057#discussion_r513312681 both methods should raise `TypeError` not `ValueError` when called with the wrong arguments. Pretty trivial change, but needs to wait for a major release.	pydantic/pydantic	a82045c97326b62599329f99496914b4bcd3da6a	2.03	[ "tests/test_main.py::test_allow_extra_from_attributes[forbid]", "tests/test_main.py::test_type_type_subclass_validation_success", "tests/test_main.py::test_frozen_field", "tests/test_main.py::test_default_factory_field", "tests/test_main.py::test_pydantic_init_subclass", "tests/test_main.py::test_validate...	[ "tests/test_main.py::test_two_defaults", "tests/test_private_attributes.py::test_default_and_default_factory_used_error" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff a82045c97326b62599...	1,098
pydantic__pydantic-9303	@skylander86, Thanks for reporting this! We can fix in a 2.7 patch release soon. Adding to the corresponding milestone! Ok I don't think this is actually a 2.7 issue (can reproduce in 2.6.4). Removing this from the 2.7 milestone, great first issue if someone wants to pick this up! Hi, I can take this.	diff --git a/pydantic/_internal/_generate_schema.py b/pydantic/_internal/_generate_schema.py --- a/pydantic/_internal/_generate_schema.py +++ b/pydantic/_internal/_generate_schema.py @@ -1442,6 +1442,7 @@ def _sequence_schema(self, sequence_type: Any) -> core_schema.CoreSchema: item_type = self._get_first_arg_...	diff --git a/tests/test_json_schema.py b/tests/test_json_schema.py --- a/tests/test_json_schema.py +++ b/tests/test_json_schema.py @@ -4942,6 +4942,36 @@ class Model(BaseModel): } +@pytest.mark.parametrize(('sequence_type',), [pytest.param(List), pytest.param(Sequence)]) +def test_sequence_schema_with_max_leng...	2024-04-23T09:18:46Z	When using min_length on Sequence field, outputted JSON schema is `minLength` instead of `minItems` for array type ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description ```python class Example(BaseModel): array: Sequence[int] = Field(default_factory=list, min_length=1) Example.model_js...	pydantic/pydantic	26129479a06960af9d02d3a948e51985fe59ed4b	2.7	[ "tests/test_json_schema.py::test_ipv6network_type", "tests/test_json_schema.py::test_typeddict_with__callable_json_schema_extra", "tests/test_json_schema.py::test_schema_attributes", "tests/test_json_schema.py::test_secrets_schema[min-max-constraints-SecretStr]", "tests/test_json_schema.py::test_dataclass_w...	[ "tests/test_json_schema.py::test_sequence_schema_with_min_length[sequence_type1]", "tests/test_json_schema.py::test_sequence_schema_with_max_length[sequence_type1]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 26129479a06960af9d...	1,112
pydantic__pydantic-8650		diff --git a/pydantic/networks.py b/pydantic/networks.py --- a/pydantic/networks.py +++ b/pydantic/networks.py @@ -479,14 +479,18 @@ def __get_pydantic_core_schema__( _handler: GetCoreSchemaHandler, ) -> core_schema.CoreSchema: import_email_validator() + return core_schema.no_info_after_...	diff --git a/tests/test_networks.py b/tests/test_networks.py --- a/tests/test_networks.py +++ b/tests/test_networks.py @@ -850,9 +850,18 @@ class Model(BaseModel): assert str(Model(v=NameEmail('foo bar', 'foobaR@example.com')).v) == 'foo bar <foobaR@example.com>' assert str(Model(v='foo bar <foobaR@example...	2024-01-26T22:08:08Z	`NameEmail` does not support parsing from json input ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description Originate from https://github.com/pydantic/pydantic/issues/7720#issuecomment-1812475489. Turns out that is an issue with implementation of `NameEmail`. Support matrix of `NameEm...	pydantic/pydantic	5fc166c031dc3665748c5ce6c0284abd5e61c195	2.6	[ "tests/test_networks.py::test_any_url_success[http://twitter.com/@handle/]", "tests/test_networks.py::test_any_url_success[http://example.org/path?query#fragment]", "tests/test_networks.py::test_any_url_success[postgresql+psycopg://postgres:postgres@localhost:5432/hatch]", "tests/test_networks.py::test_any_ur...	[ "tests/test_networks.py::test_name_email" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 5fc166c031dc366574...	1,114
pydantic__pydantic-4882	I'd be happy to contribute to this. Would be my first contribution to pydantic – do you think it's suitable? Yes absolutely, please submit a PR. Sweet! I'll get to working on this over the weekend / next week. (Meanwhile, is it possible for you to `assign` to me? Easier for me to be organized. If this is against your m...	diff --git a/docs/examples/types_undefined_warning.py b/docs/examples/types_undefined_warning.py new file mode 100644 --- /dev/null +++ b/docs/examples/types_undefined_warning.py @@ -0,0 +1,45 @@ +from __future__ import annotations + +from pydantic import BaseModel + + +# This example shows how Book and Person types re...	diff --git a/tests/test_forward_ref.py b/tests/test_forward_ref.py --- a/tests/test_forward_ref.py +++ b/tests/test_forward_ref.py @@ -1,3 +1,4 @@ +import re import sys from typing import Optional, Tuple @@ -44,6 +45,9 @@ def module(): class Foo(BaseModel): a: 'Bar' = None + class...	2022-12-27T23:18:46Z	V2: config parameter to warning about missing annotations We have [logic](https://github.com/pydantic/pydantic/blob/eaa2ad14c71138600de301d5f0ebf8fda6775788/pydantic/_internal/_model_construction.py#L203) to deal with the case where an annotation is not defined when a model is constructed, at the moment this silently s...	pydantic/pydantic	2e17c85810fd7e335422dcbf2525d019cfeb5d8c	2.0	[ "tests/test_forward_ref.py::test_self_forward_ref_module", "tests/test_forward_ref.py::test_self_forward_ref_local", "tests/test_forward_ref.py::test_forward_ref_auto_update_no_model", "tests/test_forward_ref.py::test_postponed_annotations_auto_model_rebuild", "tests/test_forward_ref.py::test_recursive_mode...	[ "tests/test_forward_ref.py::test_undefined_types_warning_1a_raised_by_default_2a_future_annotations", "tests/test_forward_ref.py::test_undefined_types_warning_1b_suppressed_via_config_2b_forward_ref", "tests/test_forward_ref.py::test_undefined_types_warning_1a_raised_by_default_2b_forward_ref" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 2e17c85810fd7e3354...	1,115
pydantic__pydantic-9193	Great catch, thank you. We'll look into it. @willbakst, Could you please provide the full traceback? Thanks! Also, could you share the full output of `pip freeze`? We're having trouble reproducing this, wondering if there's a chance it's related to other dependency versions (in particular, the version of the openai ...	diff --git a/pydantic/_internal/_generate_schema.py b/pydantic/_internal/_generate_schema.py --- a/pydantic/_internal/_generate_schema.py +++ b/pydantic/_internal/_generate_schema.py @@ -536,7 +536,7 @@ def _model_schema(self, cls: type[BaseModel]) -> core_schema.CoreSchema: assert cls.__mro__[0] is cl...	diff --git a/tests/test_generics.py b/tests/test_generics.py --- a/tests/test_generics.py +++ b/tests/test_generics.py @@ -2886,3 +2886,11 @@ class FooGeneric(TypedDict, Generic[T]): ta_foo_generic = TypeAdapter(FooGeneric[str]) assert ta_foo_generic.validate_python({'type': 'tomato'}) == {'type': 'tomato'} ...	2024-04-09T14:07:12Z	v2.7.0b1 throws error when using OpenAI SDK ### Initial Checks - [X] I confirm that I'm using Pydantic V2 ### Description Trying to generate a simple chat completion (as in below code example) throws: ```shell AttributeError: type object 'Generic' has no attribute '__annotations__' ``` I've confirmed that th...	pydantic/pydantic	8aeac1a4c61b084ebecf61b38bb8d3e80884dc33	2.7	[ "tests/test_generics.py::test_generic_recursive_models_with_a_concrete_parameter", "tests/test_generics.py::test_double_typevar_substitution", "tests/test_generics.py::test_non_generic_field", "tests/test_generics.py::test_partial_specification_with_inner_typevar", "tests/test_generics.py::test_partial_spec...	[ "tests/test_generics.py::test_generic_with_allow_extra" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8aeac1a4c61b084ebe...	1,120
pandas-dev__pandas-51854	Thanks for the report. Could you post the full traceback? > Thanks for the report. Could you post the full traceback? Sure... <details> ```python --------------------------------------------------------------------------- NotImplementedError Traceback (most recent call last) Cell In[4]...	diff --git a/pandas/core/arrays/arrow/dtype.py b/pandas/core/arrays/arrow/dtype.py index a262a45feb9c5..2ba0711de98f9 100644 --- a/pandas/core/arrays/arrow/dtype.py +++ b/pandas/core/arrays/arrow/dtype.py @@ -27,6 +27,7 @@ StorageExtensionDtype, register_extension_dtype, ) +from pandas.core.dtypes.dtypes imp...	diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index 712fccae83cfe..22920e077123e 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -39,6 +39,7 @@ from pandas.errors import PerformanceWarning from pandas.core.dtypes.common impor...	2023-03-09T00:43:39Z	BUG: Pandas 2.0rc0 can't handle string column with PyArrow (large_string error) ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [ ] I hav...	pandas-dev/pandas	acf3395aaafbc15ce461f6667f0b1d63bf3766d1	2.1	[ "pandas/tests/extension/test_arrow.py::TestBaseSetitem::test_setitem_scalar[timestamp[s,", "pandas/tests/extension/test_arrow.py::TestConstructors::test_from_dtype[timestamp[us,", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_shift_0_periods[binary]", "pandas/tests/extension/test_arrow.py::Test...	[ "pandas/tests/extension/test_arrow.py::test_arrow_dtype_type[arrow_dtype3-str]", "pandas/tests/extension/test_arrow.py::test_arrow_dtype_type[arrow_dtype7-CategoricalDtypeType]", "pandas/tests/extension/test_arrow.py::test_arrow_dtype_type[arrow_dtype5-list]", "pandas/tests/extension/test_arrow.py::test_arrow...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff acf3395aaafbc15ce4...	1,161
pandas-dev__pandas-47619	Pandas primarily uses NaN to represent missing data. Because NaN is a float, this forces an array of integers with any missing values to become floating point.So pandas introduce a extension types for (int64 -> Int64, ... ), but there isn't a need to extend float64 to Float64 because float64 is nullable (NaN is a float...	diff --git a/doc/source/whatsnew/v1.5.0.rst b/doc/source/whatsnew/v1.5.0.rst index 0b450fab53137..c70acc0a0b18c 100644 --- a/doc/source/whatsnew/v1.5.0.rst +++ b/doc/source/whatsnew/v1.5.0.rst @@ -948,7 +948,7 @@ I/O - Bug in :func:`read_sas` with RLE-compressed SAS7BDAT files that contain 0x40 control bytes (:issue:`...	diff --git a/pandas/tests/io/test_parquet.py b/pandas/tests/io/test_parquet.py index 5b899079dfffd..64e4a15a42061 100644 --- a/pandas/tests/io/test_parquet.py +++ b/pandas/tests/io/test_parquet.py @@ -626,6 +626,9 @@ def test_use_nullable_dtypes(self, engine, request): "d": pyarrow.array([True, False, ...	2022-07-06T22:23:23Z	BUG: Float Nullable dtypes not being returned when `use_nullable_dtypes=True` in `pd.read_parquet` ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas....	pandas-dev/pandas	9a8b1932186148eeb5c25e081a3a8ebaf08c55ba	1.5	[ "pandas/tests/io/test_parquet.py::TestParquetFastParquet::test_unsupported", "pandas/tests/io/test_parquet.py::test_cross_engine_fp_pa", "pandas/tests/io/test_parquet.py::TestParquetPyArrow::test_categorical", "pandas/tests/io/test_parquet.py::test_options_auto", "pandas/tests/io/test_parquet.py::TestParque...	[ "pandas/tests/io/test_parquet.py::TestBasic::test_use_nullable_dtypes[pyarrow]", "pandas/tests/io/test_parquet.py::TestBasic::test_read_empty_array[float]" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 9a8b1932186148eeb5...	1,167
pandas-dev__pandas-56538		diff --git a/pandas/core/arrays/arrow/array.py b/pandas/core/arrays/arrow/array.py index 6f7f42eca3794..d62a11f900694 100644 --- a/pandas/core/arrays/arrow/array.py +++ b/pandas/core/arrays/arrow/array.py @@ -695,22 +695,31 @@ def _evaluate_op_method(self, other, op, arrow_funcs): other = self._box_pa(other) ...	diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index de9f872aca01d..276bd1917c010 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -1330,6 +1330,26 @@ def test_arrowdtype_construct_from_string_type_only_one_pyarrow(): pd.S...	2023-12-17T19:30:08Z	ENH: Multiplication of pd.ArrowDtype(pa.string()) and int should support the integral type being a series ### Feature Type - [X] Adding new functionality to pandas - [ ] Changing existing functionality in pandas - [ ] Removing existing functionality in pandas ### Problem Description Follow up of https://github.co...	pandas-dev/pandas	d77d5e54f9fb317f61caa1985df8ca156df921e1	2.2	[ "pandas/tests/extension/test_arrow.py::TestArrowArray::test_setitem_mask[False-int32-numpy-array]", "pandas/tests/extension/test_arrow.py::TestArrowArray::test_value_counts_returns_pyarrow_int64[timestamp[ms,", "pandas/tests/extension/test_arrow.py::TestArrowArray::test_argmin_argmax[uint32]", "pandas/tests/e...	[ "pandas/tests/extension/test_arrow.py::test_arrow_string_multiplication" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff d77d5e54f9fb317f61...	1,194
pandas-dev__pandas-49156	Just to be sure > it's `other` argument should also default to ~`np.nan`~ `lib.no_default` > Just to be sure > > > it's `other` argument should also default to ~`np.nan`~ `lib.no_default` Thanks for spotting my typo, edited my post above	diff --git a/doc/source/whatsnew/v2.0.0.rst b/doc/source/whatsnew/v2.0.0.rst index 3e376d15a5a87..dc29010efada8 100644 --- a/doc/source/whatsnew/v2.0.0.rst +++ b/doc/source/whatsnew/v2.0.0.rst @@ -126,7 +126,7 @@ Other API changes - Passing data with dtype of "timedelta64[s]", "timedelta64[ms]", or "timedelta64[us]" t...	diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index 4c05fd31f53e3..d1f695bc06224 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -856,17 +856,6 @@ def test_searchsorted(self, data_for_sorting, as_series, request): ) ...	2022-10-17T19:12:34Z	API: Series/DataFrame.mask(other) should default to lib.no_default instead of np.nan In 1.4 (https://github.com/pandas-dev/pandas/pull/44697), `.where(other=)` was changed from `np.nan` to `lib.no_default`. Since `mask` is the analogous method to `where`, it's `other` argument should also default to `lib.no_default`...	pandas-dev/pandas	4583a045e7123032dbf7856429ef411713a6937b	2.0	[ "pandas/tests/extension/test_arrow.py::TestBaseSetitem::test_setitem_scalar[timestamp[s,", "pandas/tests/extension/test_arrow.py::TestBaseReshaping::test_unstack[uint32-series-index1]", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_argmax_argmin_no_skipna_notimplemented[int8]", "pandas/tests/ex...	[ "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_where_series[False-timestamp[us]]", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_where_series[False-timestamp[ns,", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_where_series[True-duration[s]]", "pandas/tests/extension...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4583a045e7123032db...	1,200
pandas-dev__pandas-56244	I'm ambivalent here. I agree with phofl that idempotency is an attractive property for the constructors. The flip side is the code/api complexity involved with treating Index[object] differently from ndarray[object]. The only strong opinion I have is that pd.Index, pd.Series, pd.array, pd.DataFrame should all have...	diff --git a/doc/source/whatsnew/v2.2.0.rst b/doc/source/whatsnew/v2.2.0.rst index 8209525721b98..89a03ddbef2a2 100644 --- a/doc/source/whatsnew/v2.2.0.rst +++ b/doc/source/whatsnew/v2.2.0.rst @@ -460,6 +460,7 @@ Other Deprecations - Deprecated behavior of :meth:`Index.insert` with an object-dtype index silently perfo...	diff --git a/pandas/_testing/__init__.py b/pandas/_testing/__init__.py index 69b2b0876fc80..672c16a85086c 100644 --- a/pandas/_testing/__init__.py +++ b/pandas/_testing/__init__.py @@ -10,6 +10,7 @@ ContextManager, cast, ) +import warnings import numpy as np @@ -285,11 +286,17 @@ def box_expected(expect...	2023-11-29T22:26:14Z	DEPR: Series and Index shouldn't do inference on pandas objects The following changes the dtype, which is unexpected: ``` idx = pd.Index(pd.date_range("2015-01-01 10:00", freq="D", periods=3), dtype=object) pd.Index(idx).dtype ``` this returns ``datetime64[ns]`` Doing inference on a pandas object is pretty ...	pandas-dev/pandas	b0ffccd489badea508d0a83431f1aea019e294b7	2.2	[ "pandas/tests/series/accessors/test_dt_accessor.py::TestSeriesDatetimeValues::test_dt_accessor_datetime_name_accessors[bs_BA.ISO8859-2]", "pandas/tests/frame/test_constructors.py::TestDataFrameConstructors::test_dict_nocopy[Float32-M8[ns]-False]", "pandas/tests/series/accessors/test_dt_accessor.py::TestSeriesDa...	[ "pandas/tests/indexes/test_base.py::TestIndex::test_constructor_from_index_dtlike[index0-True]", "pandas/tests/indexes/test_base.py::TestIndex::test_constructor_from_index_dtlike[index1-True]", "pandas/tests/series/methods/test_equals.py::test_equals_matching_nas", "pandas/tests/indexes/test_base.py::TestInde...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff b0ffccd489badea508...	1,206
pandas-dev__pandas-54186	Yes, this is clearly a bug. take	diff --git a/doc/source/whatsnew/v2.1.0.rst b/doc/source/whatsnew/v2.1.0.rst index 6c2784bc93b0c..b0c2b845073f6 100644 --- a/doc/source/whatsnew/v2.1.0.rst +++ b/doc/source/whatsnew/v2.1.0.rst @@ -481,7 +481,7 @@ Conversion - Bug in :meth:`DataFrame.__repr__` incorrectly raising a ``TypeError`` when the dtype of a col...	diff --git a/pandas/tests/io/pytables/test_select.py b/pandas/tests/io/pytables/test_select.py index f14a3ad7c5e10..8d9e0b9f5ffec 100644 --- a/pandas/tests/io/pytables/test_select.py +++ b/pandas/tests/io/pytables/test_select.py @@ -914,7 +914,7 @@ def test_query_compare_column_type(setup_path): if col...	2023-07-19T03:03:28Z	BUG: HDFStore select where condition doesn't work for large integer ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [X] I have confirmed this b...	pandas-dev/pandas	406abd95647386d136000613b6a754d40e90d0df	2.1	[ "pandas/tests/io/pytables/test_select.py::test_select_empty_where[where2]", "pandas/tests/io/pytables/test_select.py::test_frame_select_complex", "pandas/tests/io/pytables/test_select.py::test_select_empty_where[where1]", "pandas/tests/io/pytables/test_select.py::test_query_compare_column_type", "pandas/tes...	[ "pandas/tests/io/pytables/test_select.py::test_select_large_integer" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 406abd95647386d136...	1,320
pandas-dev__pandas-54428	Looks like in pd.core.internals.concat we need to change `i8values = np.full(self.shape, fill_value._value)` to `i8values = np.full(self.shape, NaT.value)` ran into this bug this AM in pandas 2.0.1 PR to address this is welcome. take	diff --git a/doc/source/whatsnew/v2.2.0.rst b/doc/source/whatsnew/v2.2.0.rst index 9eb5bbc8f07d5..e3d17977ad26c 100644 --- a/doc/source/whatsnew/v2.2.0.rst +++ b/doc/source/whatsnew/v2.2.0.rst @@ -301,6 +301,7 @@ Categorical Datetimelike ^^^^^^^^^^^^ +- Bug in :func:`concat` raising ``AttributeError`` when concaten...	diff --git a/pandas/tests/reshape/concat/test_concat.py b/pandas/tests/reshape/concat/test_concat.py index 74c79d20a3fb3..131058010808e 100644 --- a/pandas/tests/reshape/concat/test_concat.py +++ b/pandas/tests/reshape/concat/test_concat.py @@ -867,3 +867,14 @@ def test_concat_ea_upcast(): result = concat([df1, df...	2023-08-05T15:27:21Z	BUG: AttributeError raised with pd.concat between a None and Timestamp ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [X] I have confirmed thi...	pandas-dev/pandas	f32c52d07c71c38c02edc3b9a3ef9d6915c13aa5	2.2	[ "pandas/tests/reshape/concat/test_concat.py::test_concat_retain_attrs[data0]", "pandas/tests/reshape/concat/test_concat.py::test_concat_will_upcast[int-Series]", "pandas/tests/reshape/concat/test_concat.py::test_concat_preserves_subclass[obj1]", "pandas/tests/reshape/concat/test_concat.py::test_concat_will_up...	[ "pandas/tests/reshape/concat/test_concat.py::test_concat_none_with_timezone_timestamp" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff f32c52d07c71c38c02...	1,327
pandas-dev__pandas-50986		diff --git a/doc/source/whatsnew/v2.0.0.rst b/doc/source/whatsnew/v2.0.0.rst index 78422ec686da8..c959a9777b0b0 100644 --- a/doc/source/whatsnew/v2.0.0.rst +++ b/doc/source/whatsnew/v2.0.0.rst @@ -1229,6 +1229,7 @@ Numeric - Bug in DataFrame reduction methods (e.g. :meth:`DataFrame.sum`) with object dtype, ``axis=1`` ...	diff --git a/pandas/tests/extension/test_arrow.py b/pandas/tests/extension/test_arrow.py index 1b1cbc8130e4d..492de537171c3 100644 --- a/pandas/tests/extension/test_arrow.py +++ b/pandas/tests/extension/test_arrow.py @@ -1339,38 +1339,31 @@ def test_quantile(data, interpolation, quantile, request): tm.assert_s...	2023-01-26T02:26:17Z	BUG: .mode with pyarrow dtypes ignores dropna ```python ser = pd.Series([1, 1, None, None], dtype="int64[pyarrow]") ser.mode(dropna=True) ser.mode(dropna=False) ``` With either dropna=True or dropna=False, we get back `Series([1], dtype="int64[pyarrow]")`. I'd expect that with dropna=True, but expeced to get ...	pandas-dev/pandas	4965c51ef63dd06bcf460165a10bffa688142c46	2.0	[ "pandas/tests/extension/test_arrow.py::TestBaseSetitem::test_setitem_scalar[timestamp[s,", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_shift_0_periods[binary]", "pandas/tests/extension/test_arrow.py::TestBaseInterface::test_memory_usage[binary]", "pandas/tests/extension/test_arrow.py::TestBas...	[ "pandas/tests/extension/test_arrow.py::test_mode_dropna_false_mode_na[int32]", "pandas/tests/extension/test_arrow.py::test_mode_dropna_true[timestamp[us]-multi_mode]", "pandas/tests/extension/test_arrow.py::test_mode_dropna_true[binary-single_mode]", "pandas/tests/extension/test_arrow.py::test_mode_dropna_fal...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4965c51ef63dd06bcf...	1,392
pandas-dev__pandas-57205	We spend basically all our time in sanitize_array / _try_cast / `construct_1d_object_array_from_listlike` And of that, all the time is in NumPy. ``` Line # Hits Time Per Hit % Time Line Contents ============================================================== 1189 ...	diff --git a/doc/source/whatsnew/v3.0.0.rst b/doc/source/whatsnew/v3.0.0.rst index 3fdb4af52a8c0..ca50fd2037b69 100644 --- a/doc/source/whatsnew/v3.0.0.rst +++ b/doc/source/whatsnew/v3.0.0.rst @@ -166,6 +166,7 @@ Removal of prior version deprecations/changes Performance improvements ~~~~~~~~~~~~~~~~~~~~~~~~ +- Perf...	diff --git a/pandas/tests/frame/test_constructors.py b/pandas/tests/frame/test_constructors.py index 2bbb20c842dba..7d1a5b4492740 100644 --- a/pandas/tests/frame/test_constructors.py +++ b/pandas/tests/frame/test_constructors.py @@ -3042,6 +3042,11 @@ def test_columns_indexes_raise_on_sets(self): with pytest.r...	2024-02-02T02:36:52Z	DataFrame constructor with dict of series misbehaving when `columns` specified We take a strange path... ```diff diff --git a/pandas/core/internals/construction.py b/pandas/core/internals/construction.py index c43745679..54108ec58 100644 --- a/pandas/core/internals/construction.py +++ b/pandas/core/internals/c...	pandas-dev/pandas	4ed67ac9ef3d9fde6fb8441bc9ea33c0d786649e	3.0	[ "pandas/tests/frame/test_constructors.py::TestDataFrameConstructors::test_dict_nocopy[Float32-float-True]", "pandas/tests/frame/test_constructors.py::TestDataFrameConstructors::test_dict_nocopy[Float32-M8[ns]-False]", "pandas/tests/frame/test_constructors.py::TestDataFrameConstructorWithDatetimeTZ::test_constru...	[ "pandas/tests/frame/test_constructors.py::TestDataFrameConstructorWithDatetimeTZ::test_from_dict_with_columns_na_scalar" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4ed67ac9ef3d9fde6f...	1,452
pandas-dev__pandas-47841	Is someone working on this issue? If not I would like to look into this.	diff --git a/doc/source/whatsnew/v1.5.0.rst b/doc/source/whatsnew/v1.5.0.rst index a1a2149da7cf6..5a95883e12fd1 100644 --- a/doc/source/whatsnew/v1.5.0.rst +++ b/doc/source/whatsnew/v1.5.0.rst @@ -407,7 +407,6 @@ upon serialization. (Related issue :issue:`12997`) # Roundtripping now works pd.read_json(a.to_js...	diff --git a/pandas/tests/reshape/concat/test_categorical.py b/pandas/tests/reshape/concat/test_categorical.py index 5bafd2e8e8503..f00d3b369a94d 100644 --- a/pandas/tests/reshape/concat/test_categorical.py +++ b/pandas/tests/reshape/concat/test_categorical.py @@ -238,3 +238,19 @@ def test_categorical_missing_from_one_...	2022-07-24T22:42:35Z	Concatenating unordered CategoricalIndex overrides indices A very similar bug to #20425, but with `CategoricalIndex` instead of `Categorical`: #### Code Sample ```python cat1 = pd.CategoricalIndex( ["a", "a",], categories=["a", "b"], ordered=False) cat2 = pd.CategoricalIndex( ["b", "b"], ...	pandas-dev/pandas	8b72297c8799725e98cb2c6aee664325b752194f	1.5	[ "pandas/tests/reshape/concat/test_categorical.py::TestCategoricalConcat::test_categorical_index_upcast", "pandas/tests/reshape/concat/test_categorical.py::TestCategoricalConcat::test_categorical_concat[True]", "pandas/tests/reshape/concat/test_categorical.py::TestCategoricalConcat::test_concat_categorical_tz", ...	[ "pandas/tests/reshape/concat/test_categorical.py::TestCategoricalConcat::test_concat_categorical_same_categories_different_order" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 8b72297c8799725e98...	1,518
pandas-dev__pandas-55586	also happens to `last` method. I confirm this bug exists on main branch of pandas. cc @lithomas1 - if numba is not explicitly requested by passing engine, I think we need to check whether the given method has a numba implementation. Haven't checked yet - but I'm pretty certain this is a regression.	diff --git a/doc/source/whatsnew/v2.1.2.rst b/doc/source/whatsnew/v2.1.2.rst index 7c04d1a03a6e4..9d2826395b0ef 100644 --- a/doc/source/whatsnew/v2.1.2.rst +++ b/doc/source/whatsnew/v2.1.2.rst @@ -16,6 +16,7 @@ Fixed regressions - Fixed regression in :meth:`DataFrame.join` where result has missing values and dtype is ...	diff --git a/pandas/tests/groupby/test_numba.py b/pandas/tests/groupby/test_numba.py index e36c248c99ad6..ee7d342472493 100644 --- a/pandas/tests/groupby/test_numba.py +++ b/pandas/tests/groupby/test_numba.py @@ -3,6 +3,7 @@ from pandas import ( DataFrame, Series, + option_context, ) import pandas._test...	2023-10-19T02:27:14Z	BUG: TypeError: GroupBy.first() got an unexpected keyword argument 'engine' ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [ ] I have co...	pandas-dev/pandas	6f950c1c36eecce7aad3527b20da25943ebb028d	2.2	[ "pandas/tests/groupby/test_numba.py::TestEngine::test_axis_1_unsupported[sum-min_count]", "pandas/tests/groupby/test_numba.py::TestEngine::test_cython_vs_numba_getitem[False-False-True-True-max-min_count]", "pandas/tests/groupby/test_numba.py::TestEngine::test_cython_vs_numba_frame[False-False-False-True-min]",...	[ "pandas/tests/groupby/test_numba.py::TestEngine::test_no_engine_doesnt_raise" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 6f950c1c36eecce7aa...	1,613
pandas-dev__pandas-55270	[pivot_longer](https://pyjanitor-devs.github.io/pyjanitor/api/functions/#janitor.functions.pivot.pivot_longer) preserves the dtypes: ```py # pip install pyjanitor import pandas as pd import janitor df.pivot_longer(index='type', names_to='start/end', values_to='date') type start/end ...	diff --git a/doc/source/whatsnew/v2.2.0.rst b/doc/source/whatsnew/v2.2.0.rst index fa3cef6d9457d..d498c84358448 100644 --- a/doc/source/whatsnew/v2.2.0.rst +++ b/doc/source/whatsnew/v2.2.0.rst @@ -254,6 +254,7 @@ Bug fixes - Bug in :class:`AbstractHolidayCalendar` where timezone data was not propagated when computing ...	diff --git a/pandas/tests/reshape/test_melt.py b/pandas/tests/reshape/test_melt.py index 941478066a7d8..ef748e264188c 100644 --- a/pandas/tests/reshape/test_melt.py +++ b/pandas/tests/reshape/test_melt.py @@ -459,6 +459,47 @@ def test_melt_ea_columns(self): ) tm.assert_frame_equal(result, expected) ...	2023-09-25T00:44:14Z	BUG: melt method doesn't seem to preserve timezone settings. ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [X] I have confirmed this bug exis...	pandas-dev/pandas	59616c57d6abcf0fb4eb5f81928120c7b000ba88	2.2	[ "pandas/tests/reshape/test_melt.py::TestMelt::test_pandas_dtypes[col0]", "pandas/tests/reshape/test_melt.py::TestWideToLong::test_mixed_type_suffix", "pandas/tests/reshape/test_melt.py::TestMelt::test_tuple_vars_fail_with_multiindex[id_vars0-value_vars0]", "pandas/tests/reshape/test_melt.py::TestWideToLong::t...	[ "pandas/tests/reshape/test_melt.py::TestMelt::test_melt_preserves_datetime" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 59616c57d6abcf0fb4...	1,677
pandas-dev__pandas-47222	pls check in 1.2.0 and master, I believe this is fixed I'm getting the same results in the pandas 1.2.0 <details> ```python >>> pandas.show_versions() INSTALLED VERSIONS ------------------ commit : 3e89b4c4b1580aa890023fc550774e63d499da25 python : 3.8.5.final.0 python-bits : 64 ...	diff --git a/doc/source/whatsnew/v1.5.0.rst b/doc/source/whatsnew/v1.5.0.rst index 740a0f888d38f..c19352af406a8 100644 --- a/doc/source/whatsnew/v1.5.0.rst +++ b/doc/source/whatsnew/v1.5.0.rst @@ -852,6 +852,7 @@ Conversion - Bug in metaclass of generic abstract dtypes causing :meth:`DataFrame.apply` and :meth:`Series...	diff --git a/pandas/tests/apply/test_frame_apply.py b/pandas/tests/apply/test_frame_apply.py index ef7ab4a469865..72a9d8723d34c 100644 --- a/pandas/tests/apply/test_frame_apply.py +++ b/pandas/tests/apply/test_frame_apply.py @@ -1577,3 +1577,11 @@ def test_apply_type(): result = df.apply(type, axis=1) expecte...	2022-06-04T10:02:57Z	BUG: pd.apply returns a dataframe when empty dataframe instead of a series - [x] I have checked that this issue has not already been reported. - [x] I have confirmed this bug exists on the latest version of pandas. - [ ] (optional) I have confirmed this bug exists on the master branch of pandas. --- *Note...	pandas-dev/pandas	4fe2f312ce83d84169aed76fbe7270891301c086	1.5	[ "pandas/tests/apply/test_frame_apply.py::test_result_type_series_result_other_index", "pandas/tests/apply/test_frame_apply.py::test_applymap_empty[<lambda>-expected0]", "pandas/tests/apply/test_frame_apply.py::test_size_as_str[axis=0-agg]", "pandas/tests/apply/test_frame_apply.py::test_agg_axis1_duplicate_ind...	[ "pandas/tests/apply/test_frame_apply.py::test_apply_on_empty_dataframe" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4fe2f312ce83d84169...	1,682
pandas-dev__pandas-48185		diff --git a/doc/source/whatsnew/v1.6.0.rst b/doc/source/whatsnew/v1.6.0.rst index 6b7ae767d79d4..67e65cfc26764 100644 --- a/doc/source/whatsnew/v1.6.0.rst +++ b/doc/source/whatsnew/v1.6.0.rst @@ -151,7 +151,7 @@ Interval Indexing ^^^^^^^^ -- +- Bug in :meth:`DataFrame.reindex` filling with wrong values when indexi...	diff --git a/pandas/tests/frame/methods/test_reindex.py b/pandas/tests/frame/methods/test_reindex.py index 8575e7895ae5a..daa60be085fd8 100644 --- a/pandas/tests/frame/methods/test_reindex.py +++ b/pandas/tests/frame/methods/test_reindex.py @@ -772,6 +772,16 @@ def test_reindex_fill_value(self): expected = df....	2022-08-20T20:52:13Z	BUG: when re-index is filling values for both index and columns with dtype uint8 the filled values are incorrect ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/inde...	pandas-dev/pandas	e7414aa17f67d05b6ae5a7a66881178936c8b2ac	2.0	[ "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::test_reindex_nearest_tz_empty_frame", "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::test_reindex_level_verify[idx5-indexer5-True]", "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::test_re...	[ "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::test_reindex_uint_dtypes_fill_value[uint64]", "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::test_reindex_uint_dtypes_fill_value[uint16]", "pandas/tests/frame/methods/test_reindex.py::TestDataFrameSelectReindex::t...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff e7414aa17f67d05b6a...	1,711
pandas-dev__pandas-54087	I cannot reproduce this error on the most recent version of Pandas. consider closing this issue @Dr-Irv > I cannot reproduce this error on the most recent version of Pandas. consider closing this issue @Dr-Irv It's not on version 2.0.3. It's on the development version on github in the `main` branch > > I cannot re...	diff --git a/pandas/core/reshape/merge.py b/pandas/core/reshape/merge.py index 0e4a64d7e6c5f..a904f4d9fbe13 100644 --- a/pandas/core/reshape/merge.py +++ b/pandas/core/reshape/merge.py @@ -145,10 +145,12 @@ def merge( indicator: str \| bool = False, validate: str \| None = None, ) -> DataFrame: + left_df = ...	diff --git a/pandas/tests/reshape/merge/test_merge_cross.py b/pandas/tests/reshape/merge/test_merge_cross.py index 7e14b515836cf..14f9036e43fce 100644 --- a/pandas/tests/reshape/merge/test_merge_cross.py +++ b/pandas/tests/reshape/merge/test_merge_cross.py @@ -1,6 +1,9 @@ import pytest -from pandas import DataFrame ...	2023-07-11T19:18:46Z	BUG: In development version, `pd.merge` with `Series` arguments an `how="cross"` fails ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [X] I ha...	pandas-dev/pandas	dbb19b9f6ec77edcbdf535ff506c3b7659fc0c69	2.1	[ "pandas/tests/reshape/merge/test_merge_cross.py::test_merge_cross_error_reporting[kwargs3]", "pandas/tests/reshape/merge/test_merge_cross.py::test_merge_cross_null_values[NoneType]", "pandas/tests/reshape/merge/test_merge_cross.py::test_merge_cross_error_reporting[kwargs2]", "pandas/tests/reshape/merge/test_m...	[ "pandas/tests/reshape/merge/test_merge_cross.py::test_merge_cross_series" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff dbb19b9f6ec77edcbd...	1,713
pandas-dev__pandas-49124	Hi, thanks for your report. this is independent of groupby. This is because your columns are a MultiIndex. ``` df = pd.DataFrame( { ('T1', 'T2'): {('N', pd.Timestamp('2022-10-10')): 19}} ) col_name = ('T1', 'T2') rhs = df[[col_name]] df[col_name] = rhs ``` this raises a...	diff --git a/doc/source/whatsnew/v2.0.0.rst b/doc/source/whatsnew/v2.0.0.rst index 508d5d8bc4cc1..6511922fbf7b4 100644 --- a/doc/source/whatsnew/v2.0.0.rst +++ b/doc/source/whatsnew/v2.0.0.rst @@ -216,6 +216,7 @@ Interval Indexing ^^^^^^^^ - Bug in :meth:`DataFrame.reindex` filling with wrong values when indexing co...	diff --git a/pandas/tests/frame/indexing/test_setitem.py b/pandas/tests/frame/indexing/test_setitem.py index c30ffcf9a7e5b..2f103fe2496f1 100644 --- a/pandas/tests/frame/indexing/test_setitem.py +++ b/pandas/tests/frame/indexing/test_setitem.py @@ -748,6 +748,14 @@ def test_setitem_frame_overwrite_with_ea_dtype(self, a...	2022-10-15T21:56:57Z	BUG: Assigning column with tuple as name from groupby fails ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. - [X] I have confirmed this bug...	pandas-dev/pandas	90b4add77859d1349530fff3c8cadeef95f36f39	2.0	[ "pandas/tests/frame/indexing/test_setitem.py::TestDataFrameSetItemBooleanMask::test_setitem_loc_only_false_indexer_dtype_changed[Series]", "pandas/tests/frame/indexing/test_setitem.py::TestDataFrameSetItemSlicing::test_setitem_slice_indexer_broadcasting_rhs[1-list-setitem]", "pandas/tests/frame/indexing/test_se...	[ "pandas/tests/frame/indexing/test_setitem.py::TestDataFrameSetItem::test_setitem_frame_midx_columns" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 90b4add77859d13495...	1,737
pandas-dev__pandas-50232		diff --git a/doc/source/whatsnew/v2.0.0.rst b/doc/source/whatsnew/v2.0.0.rst index 4d3b2548f5fc5..caff9d7f5cb1a 100644 --- a/doc/source/whatsnew/v2.0.0.rst +++ b/doc/source/whatsnew/v2.0.0.rst @@ -775,6 +775,7 @@ Datetimelike - Bug in ``pandas.tseries.holiday.Holiday`` where a half-open date interval causes inconsiste...	diff --git a/pandas/tests/scalar/timestamp/test_timestamp.py b/pandas/tests/scalar/timestamp/test_timestamp.py index 0384417771056..5446e16c189b0 100644 --- a/pandas/tests/scalar/timestamp/test_timestamp.py +++ b/pandas/tests/scalar/timestamp/test_timestamp.py @@ -1082,3 +1082,11 @@ def test_as_unit_non_nano(self): ...	2022-12-13T13:48:19Z	WARN: warning shown when parsing delimited date string even if users can't do anything about it ### Pandas version checks - [X] I have checked that this issue has not already been reported. - [X] I have confirmed this bug exists on the [latest version](https://pandas.pydata.org/docs/whatsnew/index.html) of pandas. -...	pandas-dev/pandas	d05040824e6ab4e1611590a38172880a45dbd92f	2.0	[ "pandas/tests/scalar/timestamp/test_timestamp.py::TestNonNano::test_sub_timedelta64_mismatched_reso['UTC-02:15'-s]", "pandas/tests/scalar/timestamp/test_timestamp.py::TestNonNano::test_addsub_timedeltalike_non_nano[s-td0]", "pandas/tests/scalar/timestamp/test_timestamp.py::TestTimestampProperties::test_names[es...	[ "pandas/tests/scalar/timestamp/test_timestamp.py::test_delimited_date" ]	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff d05040824e6ab4e161...	1,797
pandas-dev__pandas-52788	I have no idea what happened to the default issue template, but someone will have to add the appropriate labels. Thanks for the report! Instead of try-except, I wonder if we should only be doing the cast to float when the type is object (so what the comment says). Also, I think the dtype in this result should be an in...	diff --git a/doc/source/user_guide/integer_na.rst b/doc/source/user_guide/integer_na.rst index a3ccb5b0d4019..1a727cd78af09 100644 --- a/doc/source/user_guide/integer_na.rst +++ b/doc/source/user_guide/integer_na.rst @@ -126,10 +126,11 @@ These dtypes can be merged, reshaped & casted. pd.concat([df[["A"]], df[["B",...	diff --git a/pandas/tests/arrays/categorical/test_analytics.py b/pandas/tests/arrays/categorical/test_analytics.py index 057005b30ae20..c42364d4d4377 100644 --- a/pandas/tests/arrays/categorical/test_analytics.py +++ b/pandas/tests/arrays/categorical/test_analytics.py @@ -9,6 +9,7 @@ from pandas import ( Categori...	2023-04-19T17:05:02Z	BUG: Summing empty DataFrame can convert to incompatible type In `DataFrame._reduce` are there reasons not to have `try/except` clauses around this conversion? https://github.com/pandas-dev/pandas/blob/029907c9d69a0260401b78a016a6c4515d8f1c40/pandas/core/frame.py#L9581-L9584 Like you have here: https://github....	pandas-dev/pandas	4d38764f25444c0e61401e583cb684d75ac858a3	2.1	[ "pandas/tests/extension/test_arrow.py::TestBaseSetitem::test_setitem_scalar[timestamp[s,", "pandas/tests/extension/test_arrow.py::TestConstructors::test_from_dtype[timestamp[us,", "pandas/tests/extension/test_arrow.py::TestBaseMethods::test_shift_0_periods[binary]", "pandas/tests/extension/test_arrow.py::Test...	[ "pandas/tests/extension/test_arrow.py::TestBaseNumericReduce::test_reduce_frame[mean-uint32-True]", "pandas/tests/extension/test_arrow.py::TestBaseNumericReduce::test_reduce_frame[min-uint16-True]", "pandas/tests/extension/test_arrow.py::TestBaseNumericReduce::test_reduce_frame[var-int8-True]", "pandas/tests/...	#!/bin/bash set -exo pipefail # Activate conda environment source /opt/miniconda3/bin/activate conda activate testbed # Navigate to testbed cd /testbed # Set git safe directory git config --global --add safe.directory /testbed # Repository state inspection cd /testbed git status git show git diff 4d38764f25444c0e61...	1,831

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.