/* 
 * Mutability Detector
 *
 * Copyright 2009 Graham Allan
 * 
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 * 
 * 		http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 */
package org.mutabilitydetector.checkers;


import static org.mutabilitydetector.checkers.AccessModifierQuery.method;

import org.mutabilitydetector.MutabilityReason;
import org.objectweb.asm.FieldVisitor;

public class PublishedNonFinalFieldChecker extends AbstractMutabilityChecker {
	
	@Override
	public FieldVisitor visitField(int access, String name, String desc, String signature, Object value) {
		if (method(access).isNotPrivate()){
			if (!method(access).isFinal()) {
				addResult("Field [" + name + "] is visible outwith this class, and is not declared final.",
						null, MutabilityReason.PUBLISHED_NON_FINAL_FIELD);
			}
		}
		return super.visitField(access, name, desc, signature, value);
	}
}

/* 
 * Mutability Detector
 *
 * Copyright 2009 Graham Allan
 * 
 * Licensed under the Apache License, Version 2.0 (the "License"); you may not
 * use this file except in compliance with the License. You may obtain a copy of
 * the License at
 * 
 * 		http://www.apache.org/licenses/LICENSE-2.0
 * 
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 * License for the specific language governing permissions and limitations under
 * the License.
 */
package org.mutabilitydetector.checkers;


import static org.mutabilitydetector.checkers.AccessModifierQuery.field;

import org.mutabilitydetector.MutabilityReason;
import org.objectweb.asm.FieldVisitor;

public class PublishedNonFinalFieldChecker extends AbstractMutabilityChecker {
	
	@Override
	public FieldVisitor visitField(int access, String name, String desc, String signature, Object value) {
		if (field(access).isNotPrivate() && field(access).isNotFinal()) {
			addResult("Field [" + name + "] is visible outwith this class, and is not declared final.",
					null, 
					MutabilityReason.PUBLISHED_NON_FINAL_FIELD);
		}
		return super.visitField(access, name, desc, signature, value);
	}
}

Make the access check code a bit more readable.